pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix the makefiles to fail cleanly if Perl is needed but not
3+ messages / 2 participants
[nested] [flat]

* pgsql: Fix the makefiles to fail cleanly if Perl is needed but not
@ 2009-06-23 03:46 Tom Lane <tgl@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: tgl@postgresql.org @ 2009-06-23 03:46 UTC (permalink / raw)
  To: pgsql-committers

Log Message:
-----------
Fix the makefiles to fail cleanly if Perl is needed but not present.  This
used to work as intended, but got broken some time ago (a quoted empty string
is not an empty string), and got broken some more by the changes to generate
ecpg's preproc.y automatically.  Given all the unprotected uses of $(PERL)
elsewhere, it seems best to make use of the $(missing) script rather than
trying to ensure each such use is protected individually.  Also fix various
bits of documentation that omitted to mention Perl as a requirement for
building from a CVS pull.  Per a complaint from Robert Haas.

Modified Files:
--------------
    pgsql:
        README.CVS (r1.3 -> r1.4)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/README.CVS?r1=1.3&r2=1.4)
    pgsql/config:
        missing (r1.4 -> r1.5)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/config/missing?r1=1.4&r2=1.5)
    pgsql/doc/src/sgml:
        cvs.sgml (r1.50 -> r1.51)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/cvs.sgml?r1=1.50&r2=1.51)
        installation.sgml (r1.324 -> r1.325)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/installation.sgml?r1=1.324&r2=1.325)
    pgsql/src:
        Makefile.global.in (r1.253 -> r1.254)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/Makefile.global.in?r1=1.253&r2=1.254)
    pgsql/src/bin/psql:
        Makefile (r1.62 -> r1.63)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/Makefile?r1=1.62&r2=1.63)




^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix initdb's -c option to treat the GUC name case-insensitively.
@ 2024-03-04 17:01 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2024-03-04 17:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix initdb's -c option to treat the GUC name case-insensitively.

The backend treats GUC names case-insensitively, so this code should
too.  This avoids ending up with a confusing set of redundant entries
in the generated postgresql.conf file.

Per report from Kyotaro Horiguchi.  Back-patch to v16 where this
feature was added (in commit 3e51b278d).

Discussion: https://postgr.es/m/20230928.164904.2153358973162534034.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fce2ce797c412df8b794b8a92c5a586db5e1bedc

Modified Files
--------------
src/bin/initdb/initdb.c        |  9 +++++++--
src/bin/initdb/t/001_initdb.pl | 14 ++++++++++++++
2 files changed, 21 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix initdb's -c option to treat the GUC name case-insensitively.
@ 2024-03-04 17:01 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2024-03-04 17:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix initdb's -c option to treat the GUC name case-insensitively.

The backend treats GUC names case-insensitively, so this code should
too.  This avoids ending up with a confusing set of redundant entries
in the generated postgresql.conf file.

Per report from Kyotaro Horiguchi.  Back-patch to v16 where this
feature was added (in commit 3e51b278d).

Discussion: https://postgr.es/m/20230928.164904.2153358973162534034.horikyota.ntt@gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b78f4d22b2f21a3efd1cb8969c9e8fa1f52466c5

Modified Files
--------------
src/bin/initdb/initdb.c        |  9 +++++++--
src/bin/initdb/t/001_initdb.pl | 14 ++++++++++++++
2 files changed, 21 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2024-03-04 17:01 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-23 03:46 pgsql: Fix the makefiles to fail cleanly if Perl is needed but not Tom Lane <tgl@postgresql.org>
2024-03-04 17:01 pgsql: Fix initdb's -c option to treat the GUC name case-insensitively. Tom Lane <tgl@sss.pgh.pa.us>
2024-03-04 17:01 pgsql: Fix initdb's -c option to treat the GUC name case-insensitively. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox