pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Revert addition of "o" to tar options.
7+ messages / 2 participants
[nested] [flat]
* pgsql: Revert addition of "o" to tar options.
@ 2009-06-27 21:06 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 7+ messages in thread
From: tgl@postgresql.org @ 2009-06-27 21:06 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Revert addition of "o" to tar options. This was intended to fix bug #4883,
but the cure appears to be worse than the disease. It turns out that GNU
tar versions 1.14.x misinterpret -o as --same-owner, not --no-same-owner,
leading to exactly the wrong behavior for both root and nonroot users.
While that bug has been fixed for nearly five years, these tar versions
are still found in the wild, notably in OS X 10.4. Given that #4883 was
the first complaint we'd heard, it's definitely not worth fixing at the
risk of breaking things for other users. Perhaps revisit at a later date
when we're not up against a release deadline.
Modified Files:
--------------
pgsql/doc:
Makefile (r1.36 -> r1.37)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/Makefile?r1=1.36&r2=1.37)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting.
@ 2024-03-08 00:38 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-08 00:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Cope with a deficiency in OpenSSL 3.x's error reporting.
In OpenSSL 3.0.0 and later, ERR_reason_error_string randomly refuses
to provide a string for error codes representing system errno values
(e.g., "No such file or directory"). There is a poorly-documented way
to extract the errno from the SSL error code in this case, so do that
and apply strerror, rather than falling back to reporting the error
code's numeric value as we were previously doing.
Problem reported by David Zhang, although this is not his proposed
patch; it's instead based on a suggestion from Heikki Linnakangas.
Back-patch to all supported branches, since any of them are likely
to be used with recent OpenSSL.
Discussion: https://postgr.es/m/b6fb018b-f05c-4afd-abd3-318c649faf18@highgo.ca
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/473babd4290e88a6d01b52f19dc0ec54e3fbcd73
Modified Files
--------------
src/backend/libpq/be-secure-openssl.c | 19 ++++++++++++++++---
src/interfaces/libpq/fe-secure-openssl.c | 23 ++++++++++++++++++++---
2 files changed, 36 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting.
@ 2024-03-08 00:38 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-08 00:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Cope with a deficiency in OpenSSL 3.x's error reporting.
In OpenSSL 3.0.0 and later, ERR_reason_error_string randomly refuses
to provide a string for error codes representing system errno values
(e.g., "No such file or directory"). There is a poorly-documented way
to extract the errno from the SSL error code in this case, so do that
and apply strerror, rather than falling back to reporting the error
code's numeric value as we were previously doing.
Problem reported by David Zhang, although this is not his proposed
patch; it's instead based on a suggestion from Heikki Linnakangas.
Back-patch to all supported branches, since any of them are likely
to be used with recent OpenSSL.
Discussion: https://postgr.es/m/b6fb018b-f05c-4afd-abd3-318c649faf18@highgo.ca
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0fe82e45cbedbe840f00d834cc6cae55593ef8cf
Modified Files
--------------
src/backend/libpq/be-secure-openssl.c | 19 ++++++++++++++++---
src/interfaces/libpq/fe-secure-openssl.c | 23 ++++++++++++++++++++---
2 files changed, 36 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting.
@ 2024-03-08 00:38 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-08 00:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Cope with a deficiency in OpenSSL 3.x's error reporting.
In OpenSSL 3.0.0 and later, ERR_reason_error_string randomly refuses
to provide a string for error codes representing system errno values
(e.g., "No such file or directory"). There is a poorly-documented way
to extract the errno from the SSL error code in this case, so do that
and apply strerror, rather than falling back to reporting the error
code's numeric value as we were previously doing.
Problem reported by David Zhang, although this is not his proposed
patch; it's instead based on a suggestion from Heikki Linnakangas.
Back-patch to all supported branches, since any of them are likely
to be used with recent OpenSSL.
Discussion: https://postgr.es/m/b6fb018b-f05c-4afd-abd3-318c649faf18@highgo.ca
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/6a2c80e955a83e8683f1f4d1ef583250bc4b9631
Modified Files
--------------
src/backend/libpq/be-secure-openssl.c | 19 ++++++++++++++++---
src/interfaces/libpq/fe-secure-openssl.c | 23 ++++++++++++++++++++---
2 files changed, 36 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting.
@ 2024-03-08 00:38 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-08 00:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Cope with a deficiency in OpenSSL 3.x's error reporting.
In OpenSSL 3.0.0 and later, ERR_reason_error_string randomly refuses
to provide a string for error codes representing system errno values
(e.g., "No such file or directory"). There is a poorly-documented way
to extract the errno from the SSL error code in this case, so do that
and apply strerror, rather than falling back to reporting the error
code's numeric value as we were previously doing.
Problem reported by David Zhang, although this is not his proposed
patch; it's instead based on a suggestion from Heikki Linnakangas.
Back-patch to all supported branches, since any of them are likely
to be used with recent OpenSSL.
Discussion: https://postgr.es/m/b6fb018b-f05c-4afd-abd3-318c649faf18@highgo.ca
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c42e5fdcfa1b2ed1def2b10c771bf0149115df08
Modified Files
--------------
src/backend/libpq/be-secure-openssl.c | 19 ++++++++++++++++---
src/interfaces/libpq/fe-secure-openssl.c | 23 ++++++++++++++++++++---
2 files changed, 36 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting.
@ 2024-03-08 00:38 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-08 00:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Cope with a deficiency in OpenSSL 3.x's error reporting.
In OpenSSL 3.0.0 and later, ERR_reason_error_string randomly refuses
to provide a string for error codes representing system errno values
(e.g., "No such file or directory"). There is a poorly-documented way
to extract the errno from the SSL error code in this case, so do that
and apply strerror, rather than falling back to reporting the error
code's numeric value as we were previously doing.
Problem reported by David Zhang, although this is not his proposed
patch; it's instead based on a suggestion from Heikki Linnakangas.
Back-patch to all supported branches, since any of them are likely
to be used with recent OpenSSL.
Discussion: https://postgr.es/m/b6fb018b-f05c-4afd-abd3-318c649faf18@highgo.ca
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9fbe07275167a890467b43ac921f4fd614c1dfd5
Modified Files
--------------
src/backend/libpq/be-secure-openssl.c | 19 ++++++++++++++++---
src/interfaces/libpq/fe-secure-openssl.c | 23 ++++++++++++++++++++---
2 files changed, 36 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting.
@ 2024-03-08 00:38 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-08 00:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Cope with a deficiency in OpenSSL 3.x's error reporting.
In OpenSSL 3.0.0 and later, ERR_reason_error_string randomly refuses
to provide a string for error codes representing system errno values
(e.g., "No such file or directory"). There is a poorly-documented way
to extract the errno from the SSL error code in this case, so do that
and apply strerror, rather than falling back to reporting the error
code's numeric value as we were previously doing.
Problem reported by David Zhang, although this is not his proposed
patch; it's instead based on a suggestion from Heikki Linnakangas.
Back-patch to all supported branches, since any of them are likely
to be used with recent OpenSSL.
Discussion: https://postgr.es/m/b6fb018b-f05c-4afd-abd3-318c649faf18@highgo.ca
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/453c46873774219243501b8efc16b2b5a5e9d194
Modified Files
--------------
src/backend/libpq/be-secure-openssl.c | 19 ++++++++++++++++---
src/interfaces/libpq/fe-secure-openssl.c | 23 ++++++++++++++++++++---
2 files changed, 36 insertions(+), 6 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-03-08 00:38 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-27 21:06 pgsql: Revert addition of "o" to tar options. Tom Lane <tgl@postgresql.org>
2024-03-08 00:38 pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting. Tom Lane <tgl@sss.pgh.pa.us>
2024-03-08 00:38 pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting. Tom Lane <tgl@sss.pgh.pa.us>
2024-03-08 00:38 pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting. Tom Lane <tgl@sss.pgh.pa.us>
2024-03-08 00:38 pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting. Tom Lane <tgl@sss.pgh.pa.us>
2024-03-08 00:38 pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting. Tom Lane <tgl@sss.pgh.pa.us>
2024-03-08 00:38 pgsql: Cope with a deficiency in OpenSSL 3.x's error reporting. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox