pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg-migrator - pg_migrator: Grammar police.
2+ messages / 2 participants
[nested] [flat]
* pg-migrator - pg_migrator: Grammar police.
@ 2009-07-03 16:46 User Tgl <tgl@pgfoundry.org>
0 siblings, 0 replies; 2+ messages in thread
From: tgl@pgfoundry.org @ 2009-07-03 16:46 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Grammar police.
Modified Files:
--------------
pg_migrator/src:
pg_migrator.c (r1.55 -> r1.56)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/src/pg_migrator.c?r1=1.55&r2...)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Don't destroy SMgrRelations at relcache invalidation
@ 2024-03-11 07:09 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Linnakangas @ 2024-03-11 07:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Don't destroy SMgrRelations at relcache invalidation
With commit 21d9c3ee4e, SMgrRelations remain valid until end of
transaction (or longer if they're "pinned"). Relcache invalidation can
happen in the middle of a transaction, so we must not destroy them at
relcache invalidation anymore.
This was revealed by failures in the 'constraints' test in buildfarm
animals using -DCLOBBER_CACHE_ALWAYS. That started failing with commit
8af2565248, which was the first commit that started to rely on an
SMgrRelation living until end of transaction.
Diagnosed-by: Tomas Vondra, Thomas Munro
Reviewed-by: Thomas Munro
Discussion: https://www.postgresql.org/message-id/CA%2BhUKGK%2B5DOmLaBp3Z7C4S-Yv6yoROvr1UncjH2S1ZbPT8D%2BZg%40ma...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/af0e7deb4a1c369bb8154ac55f085d6a93fe5c35
Modified Files
--------------
src/backend/storage/smgr/smgr.c | 2 --
src/backend/utils/cache/relcache.c | 10 +++-------
2 files changed, 3 insertions(+), 9 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-03-11 07:09 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-03 16:46 pg-migrator - pg_migrator: Grammar police. User Tgl <tgl@pgfoundry.org>
2024-03-11 07:09 pgsql: Don't destroy SMgrRelations at relcache invalidation Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox