pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix handling of changed-Param signaling for CteScan plan nodes.
3+ messages / 2 participants
[nested] [flat]
* pgsql: Fix handling of changed-Param signaling for CteScan plan nodes.
@ 2009-07-06 02:16 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: tgl@postgresql.org @ 2009-07-06 02:16 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Fix handling of changed-Param signaling for CteScan plan nodes. We were using
the "cteParam" as a proxy for the possibility that the underlying CTE plan
depends on outer-level variables or Params, but that doesn't work very well
because it sometimes causes calling subqueries to be treated as SubPlans when
they could be InitPlans. This is inefficient and also causes the outright
failure exhibited in bug #4902. Instead, leave the cteParam out of it and
copy the underlying CTE plan's extParams directly. Per bug #4902 from
Marko Tiikkaja.
Modified Files:
--------------
pgsql/src/backend/optimizer/plan:
subselect.c (r1.150 -> r1.151)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/subselect.c?r1=1.150&r...)
pgsql/src/test/regress/expected:
with.out (r1.10 -> r1.11)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/with.out?r1=1.10&r2=1.1...)
pgsql/src/test/regress/sql:
with.sql (r1.9 -> r1.10)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/with.sql?r1=1.9&r2=1.10)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix handling of changed-Param signaling for CteScan plan nodes.
@ 2009-07-06 02:16 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: tgl@postgresql.org @ 2009-07-06 02:16 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Fix handling of changed-Param signaling for CteScan plan nodes. We were using
the "cteParam" as a proxy for the possibility that the underlying CTE plan
depends on outer-level variables or Params, but that doesn't work very well
because it sometimes causes calling subqueries to be treated as SubPlans when
they could be InitPlans. This is inefficient and also causes the outright
failure exhibited in bug #4902. Instead, leave the cteParam out of it and
copy the underlying CTE plan's extParams directly. Per bug #4902 from
Marko Tiikkaja.
Tags:
----
REL8_4_STABLE
Modified Files:
--------------
pgsql/src/backend/optimizer/plan:
subselect.c (r1.150 -> r1.150.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/subselect.c?r1=1.150&r...)
pgsql/src/test/regress/expected:
with.out (r1.10 -> r1.10.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/with.out?r1=1.10&r2=1.1...)
pgsql/src/test/regress/sql:
with.sql (r1.9 -> r1.9.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/with.sql?r1=1.9&r2=1.9.2.1)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: clusterdb: Allow specifying tables to process in all databases.
@ 2024-03-11 18:13 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: Nathan Bossart @ 2024-03-11 18:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
clusterdb: Allow specifying tables to process in all databases.
Presently, clusterdb's --table option cannot be used together with
--all, i.e., you cannot specify tables to process in all databases.
This commit removes this unnecessary restriction. In passing,
change the synopsis in the documentation to use "[option...]"
instead of "[--verbose | -v]". There are other general-purpose
options (e.g., --quiet and --echo), but the synopsis currently only
lists --verbose.
Reviewed-by: Kyotaro Horiguchi, Dean Rasheed
Discussion: https://postgr.es/m/20230628232402.GA1954626%40nathanxps13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1b49d56d358a9c2e310d66c0ac87216d9b932b78
Modified Files
--------------
doc/src/sgml/ref/clusterdb.sgml | 17 ++++++++---------
src/bin/scripts/clusterdb.c | 28 +++++++++++++++++++---------
src/bin/scripts/t/011_clusterdb_all.pl | 11 +++++++++++
3 files changed, 38 insertions(+), 18 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-03-11 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-06 02:16 pgsql: Fix handling of changed-Param signaling for CteScan plan nodes. Tom Lane <tgl@postgresql.org>
2009-07-06 02:16 pgsql: Fix handling of changed-Param signaling for CteScan plan nodes. Tom Lane <tgl@postgresql.org>
2024-03-11 18:13 pgsql: clusterdb: Allow specifying tables to process in all databases. Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox