pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg-migrator - pg_migrator: Stamp 8.4 final.
8+ messages / 2 participants
[nested] [flat]
* pg-migrator - pg_migrator: Stamp 8.4 final.
@ 2009-07-06 15:07 User Bmomjian <bmomjian@pgfoundry.org>
0 siblings, 0 replies; 8+ messages in thread
From: bmomjian@pgfoundry.org @ 2009-07-06 15:07 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Stamp 8.4 final. Adjust --version string.
Modified Files:
--------------
pg_migrator/src:
option.c (r1.24 -> r1.25)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/src/option.c?r1=1.24&r2=1.25)
pg_migrator.h (r1.61 -> r1.62)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/src/pg_migrator.h?r1=1.61&r2...)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pg-migrator - pg_migrator: Stamp 8.4 final.
@ 2009-07-06 15:07 User Bmomjian <bmomjian@pgfoundry.org>
0 siblings, 0 replies; 8+ messages in thread
From: bmomjian@pgfoundry.org @ 2009-07-06 15:07 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Stamp 8.4 final. Adjust --version string.
Modified Files:
--------------
pg_migrator:
README (r1.46 -> r1.47)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/README?r1=1.46&r2=1.47)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Disconnect if socket cannot be put into non-blocking mode
@ 2024-03-12 08:40 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 8+ messages in thread
From: Heikki Linnakangas @ 2024-03-12 08:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disconnect if socket cannot be put into non-blocking mode
Commit 387da18874 moved the code to put socket into non-blocking mode
from socket_set_nonblocking() into the one-time initialization
function, pq_init(). In socket_set_nonblocking(), there indeed was a
risk of recursion on failure like the comment said, but in pq_init(),
ERROR or FATAL is fine. There's even another elog(FATAL) just after
this, if setting FD_CLOEXEC fails.
Note that COMMERROR merely logged the error, it did not close the
connection, so if putting the socket to non-blocking mode failed we
would use the connection anyway. You might not immediately notice,
because most socket operations in a regular backend wait for the
socket to become readable/writable anyway. But e.g. replication will
be quite broken.
Backpatch to all supported versions.
Discussion: https://www.postgresql.org/message-id/d40a5cd0-2722-40c5-8755-12e9e811fa3c@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f8c5317d001556a51441fad81e8f6c32994f2d79
Modified Files
--------------
src/backend/libpq/pqcomm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Disconnect if socket cannot be put into non-blocking mode
@ 2024-03-12 08:40 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 8+ messages in thread
From: Heikki Linnakangas @ 2024-03-12 08:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disconnect if socket cannot be put into non-blocking mode
Commit 387da18874 moved the code to put socket into non-blocking mode
from socket_set_nonblocking() into the one-time initialization
function, pq_init(). In socket_set_nonblocking(), there indeed was a
risk of recursion on failure like the comment said, but in pq_init(),
ERROR or FATAL is fine. There's even another elog(FATAL) just after
this, if setting FD_CLOEXEC fails.
Note that COMMERROR merely logged the error, it did not close the
connection, so if putting the socket to non-blocking mode failed we
would use the connection anyway. You might not immediately notice,
because most socket operations in a regular backend wait for the
socket to become readable/writable anyway. But e.g. replication will
be quite broken.
Backpatch to all supported versions.
Discussion: https://www.postgresql.org/message-id/d40a5cd0-2722-40c5-8755-12e9e811fa3c@iki.fi
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/539e328b1c3a4047c7ff525524edbcca2bac6e10
Modified Files
--------------
src/backend/libpq/pqcomm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Disconnect if socket cannot be put into non-blocking mode
@ 2024-03-12 08:40 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 8+ messages in thread
From: Heikki Linnakangas @ 2024-03-12 08:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disconnect if socket cannot be put into non-blocking mode
Commit 387da18874 moved the code to put socket into non-blocking mode
from socket_set_nonblocking() into the one-time initialization
function, pq_init(). In socket_set_nonblocking(), there indeed was a
risk of recursion on failure like the comment said, but in pq_init(),
ERROR or FATAL is fine. There's even another elog(FATAL) just after
this, if setting FD_CLOEXEC fails.
Note that COMMERROR merely logged the error, it did not close the
connection, so if putting the socket to non-blocking mode failed we
would use the connection anyway. You might not immediately notice,
because most socket operations in a regular backend wait for the
socket to become readable/writable anyway. But e.g. replication will
be quite broken.
Backpatch to all supported versions.
Discussion: https://www.postgresql.org/message-id/d40a5cd0-2722-40c5-8755-12e9e811fa3c@iki.fi
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4fce5f970d584114ba9f981b367eb7720621cc50
Modified Files
--------------
src/backend/libpq/pqcomm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Disconnect if socket cannot be put into non-blocking mode
@ 2024-03-12 08:40 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 8+ messages in thread
From: Heikki Linnakangas @ 2024-03-12 08:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disconnect if socket cannot be put into non-blocking mode
Commit 387da18874 moved the code to put socket into non-blocking mode
from socket_set_nonblocking() into the one-time initialization
function, pq_init(). In socket_set_nonblocking(), there indeed was a
risk of recursion on failure like the comment said, but in pq_init(),
ERROR or FATAL is fine. There's even another elog(FATAL) just after
this, if setting FD_CLOEXEC fails.
Note that COMMERROR merely logged the error, it did not close the
connection, so if putting the socket to non-blocking mode failed we
would use the connection anyway. You might not immediately notice,
because most socket operations in a regular backend wait for the
socket to become readable/writable anyway. But e.g. replication will
be quite broken.
Backpatch to all supported versions.
Discussion: https://www.postgresql.org/message-id/d40a5cd0-2722-40c5-8755-12e9e811fa3c@iki.fi
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/bf1f593e899ee9aa1de80164a3005b02474deb50
Modified Files
--------------
src/backend/libpq/pqcomm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Disconnect if socket cannot be put into non-blocking mode
@ 2024-03-12 08:40 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 8+ messages in thread
From: Heikki Linnakangas @ 2024-03-12 08:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disconnect if socket cannot be put into non-blocking mode
Commit 387da18874 moved the code to put socket into non-blocking mode
from socket_set_nonblocking() into the one-time initialization
function, pq_init(). In socket_set_nonblocking(), there indeed was a
risk of recursion on failure like the comment said, but in pq_init(),
ERROR or FATAL is fine. There's even another elog(FATAL) just after
this, if setting FD_CLOEXEC fails.
Note that COMMERROR merely logged the error, it did not close the
connection, so if putting the socket to non-blocking mode failed we
would use the connection anyway. You might not immediately notice,
because most socket operations in a regular backend wait for the
socket to become readable/writable anyway. But e.g. replication will
be quite broken.
Backpatch to all supported versions.
Discussion: https://www.postgresql.org/message-id/d40a5cd0-2722-40c5-8755-12e9e811fa3c@iki.fi
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ad5cd55e675c6b55a521d9db5e57bba5a02a9208
Modified Files
--------------
src/backend/libpq/pqcomm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Disconnect if socket cannot be put into non-blocking mode
@ 2024-03-12 08:40 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 8+ messages in thread
From: Heikki Linnakangas @ 2024-03-12 08:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disconnect if socket cannot be put into non-blocking mode
Commit 387da18874 moved the code to put socket into non-blocking mode
from socket_set_nonblocking() into the one-time initialization
function, pq_init(). In socket_set_nonblocking(), there indeed was a
risk of recursion on failure like the comment said, but in pq_init(),
ERROR or FATAL is fine. There's even another elog(FATAL) just after
this, if setting FD_CLOEXEC fails.
Note that COMMERROR merely logged the error, it did not close the
connection, so if putting the socket to non-blocking mode failed we
would use the connection anyway. You might not immediately notice,
because most socket operations in a regular backend wait for the
socket to become readable/writable anyway. But e.g. replication will
be quite broken.
Backpatch to all supported versions.
Discussion: https://www.postgresql.org/message-id/d40a5cd0-2722-40c5-8755-12e9e811fa3c@iki.fi
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/df27d76d32f2c1a2572983a5c6a874d003cd0321
Modified Files
--------------
src/backend/libpq/pqcomm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2024-03-12 08:40 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-06 15:07 pg-migrator - pg_migrator: Stamp 8.4 final. User Bmomjian <bmomjian@pgfoundry.org>
2009-07-06 15:07 pg-migrator - pg_migrator: Stamp 8.4 final. User Bmomjian <bmomjian@pgfoundry.org>
2024-03-12 08:40 pgsql: Disconnect if socket cannot be put into non-blocking mode Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-03-12 08:40 pgsql: Disconnect if socket cannot be put into non-blocking mode Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-03-12 08:40 pgsql: Disconnect if socket cannot be put into non-blocking mode Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-03-12 08:40 pgsql: Disconnect if socket cannot be put into non-blocking mode Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-03-12 08:40 pgsql: Disconnect if socket cannot be put into non-blocking mode Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-03-12 08:40 pgsql: Disconnect if socket cannot be put into non-blocking mode Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox