Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id C8282634A2D for ; Tue, 7 Jul 2009 13:29:32 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 44929-01-3 for ; Tue, 7 Jul 2009 13:29:19 -0300 (ADT) Received: from cvs.postgresql.org (cvs.postgresql.org [217.196.146.206]) by mail.postgresql.org (Postfix) with ESMTP id A3D8D634993 for ; Tue, 7 Jul 2009 13:28:39 -0300 (ADT) Received: by cvs.postgresql.org (Postfix, from userid 1007) id B5F2975331E; Tue, 7 Jul 2009 16:28:38 +0000 (UTC) MIME-Version: 1.0 To: pgsql-committers@postgresql.org Subject: pgsql: Code review for patch to show definition of index columns in \d X-Mailer: activitymail 1.24, http://search.cpan.org/dist/activitymail/ Content-Type: text/plain Message-Id: <20090707162838.B5F2975331E@cvs.postgresql.org> Date: Tue, 7 Jul 2009 16:28:38 +0000 (UTC) From: tgl@postgresql.org (Tom Lane) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.002 tagged_above=0 required=5 tests=AWL=0.002 X-Spam-Level: X-Archive-Number: 200907/83 X-Sequence-Number: 37686 Log Message: ----------- Code review for patch to show definition of index columns in \d on index. Safely schema-qualify the pg_get_indexdef call, make the query a bit prettier in -E mode, remove useless join to pg_index, make it more obvious that the header[] array is not overrun. Modified Files: -------------- pgsql/src/bin/psql: describe.c (r1.220 -> r1.221) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/describe.c?r1=1.220&r2=1.221)