pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgtcl - libpgtcl: * In pg_select code, correct memory allocation for
2+ messages / 2 participants
[nested] [flat]
* pgtcl - libpgtcl: * In pg_select code, correct memory allocation for
@ 2009-07-08 03:49 User Karl <karl@pgfoundry.org>
0 siblings, 0 replies; 2+ messages in thread
From: karl@pgfoundry.org @ 2009-07-08 03:49 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
* In pg_select code, correct memory allocation for columnNameObjs to
use the size of a pointer to Tcl_Obj times the number of columns,
rather than the size of a Tcl_Obj times the number of columns..
Modified Files:
--------------
libpgtcl:
ChangeLog (r1.59 -> r1.60)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgtcl/libpgtcl/ChangeLog?r1=1.59&r2=1.60)
libpgtcl/generic:
pgtclCmds.c (r1.75 -> r1.76)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgtcl/libpgtcl/generic/pgtclCmds.c?r1=1.75&r2=1.76)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Add the system identifier to backup manifests.
@ 2024-03-13 19:13 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: Robert Haas @ 2024-03-13 19:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Add the system identifier to backup manifests.
Before this patch, if you took a full backup on server A and then
tried to use the backup manifest to take an incremental backup on
server B, it wouldn't know that the manifest was from a different
server and so the incremental backup operation could potentially
complete without error. When you later tried to run pg_combinebackup,
you'd find out that your incremental backup was and always had been
invalid. That's poor timing, because nobody likes finding out about
backup problems only at restore time.
With this patch, you'll get an error when trying to take the (invalid)
incremental backup, which seems a lot nicer.
Amul Sul, revised by me. Review by Michael Paquier.
Discussion: http://postgr.es/m/CA+TgmoYLZzbSAMM3cAjV4Y+iCRZn-bR9H2+Mdz7NdaJFU1Zb5w@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2041bc4276c95ac014510032e622a4baf70b29f1
Modified Files
--------------
doc/src/sgml/backup-manifest.sgml | 17 +++++-
doc/src/sgml/ref/pg_verifybackup.sgml | 7 ++-
src/backend/backup/backup_manifest.c | 7 ++-
src/backend/backup/basebackup_incremental.c | 40 +++++++++++++
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 16 ++++++
src/bin/pg_combinebackup/load_manifest.c | 31 ++++++++++
src/bin/pg_combinebackup/load_manifest.h | 1 +
src/bin/pg_combinebackup/pg_combinebackup.c | 34 +++++++++--
src/bin/pg_combinebackup/t/005_integrity.pl | 14 +++++
src/bin/pg_combinebackup/write_manifest.c | 8 ++-
src/bin/pg_combinebackup/write_manifest.h | 3 +-
src/bin/pg_verifybackup/pg_verifybackup.c | 82 ++++++++++++++++++++++++++-
src/bin/pg_verifybackup/t/003_corruption.pl | 26 ++++++++-
src/bin/pg_verifybackup/t/005_bad_manifest.pl | 6 +-
src/common/parse_manifest.c | 76 ++++++++++++++++++++++++-
src/include/common/parse_manifest.h | 6 ++
16 files changed, 351 insertions(+), 23 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-03-13 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-08 03:49 pgtcl - libpgtcl: * In pg_select code, correct memory allocation for User Karl <karl@pgfoundry.org>
2024-03-13 19:13 pgsql: Add the system identifier to backup manifests. Robert Haas <rhaas@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox