Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 4BC4763467C for ; Thu, 9 Jul 2009 21:32:30 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 80859-04 for ; Thu, 9 Jul 2009 21:32:11 -0300 (ADT) Received: from cvs.postgresql.org (cvs.postgresql.org [217.196.146.206]) by mail.postgresql.org (Postfix) with ESMTP id 850C0634314 for ; Thu, 9 Jul 2009 21:32:19 -0300 (ADT) Received: by cvs.postgresql.org (Postfix, from userid 1007) id E84D0753336; Fri, 10 Jul 2009 00:32:17 +0000 (UTC) MIME-Version: 1.0 To: pgsql-committers@postgresql.org Subject: pgsql: Fix xslt_process() to ensure that it inserts a NULL terminator X-Mailer: activitymail 1.24, http://search.cpan.org/dist/activitymail/ Content-Type: text/plain Message-Id: <20090710003217.E84D0753336@cvs.postgresql.org> Date: Fri, 10 Jul 2009 00:32:17 +0000 (UTC) From: tgl@postgresql.org (Tom Lane) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.002 tagged_above=0 required=5 tests=AWL=0.002 X-Spam-Level: X-Archive-Number: 200907/107 X-Sequence-Number: 37710 Log Message: ----------- Fix xslt_process() to ensure that it inserts a NULL terminator after the last pair of parameter name/value strings, even when there are MAXPARAMS of them. Aboriginal bug in contrib/xml2, noted while studying bug #4912 (though I'm not sure whether there's something else involved in that report). This might be thought a security issue, since it's a potential backend crash; but considering that untrustworthy users shouldn't be allowed to get their hands on xslt_process() anyway, it's probably not worth getting excited about. Tags: ---- REL8_2_STABLE Modified Files: -------------- pgsql/contrib/xml2: xslt_proc.c (r1.7 -> r1.7.2.1) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/xml2/xslt_proc.c?r1=1.7&r2=1.7.2.1)