pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Rearrangement of the HTML docs build rules Set up proper
4+ messages / 2 participants
[nested] [flat]
* pgsql: Rearrangement of the HTML docs build rules Set up proper
@ 2009-07-14 22:16 Peter Eisentraut <petere@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: petere@postgresql.org @ 2009-07-14 22:16 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Rearrangement of the HTML docs build rules
Set up proper makefile dependencies in the documentation build rules,
especially around the HTML/index build. The problem we've had with all
previous solutions is that we have used the same file name, such as HTML.index
or bookindex.sgml, to mean different things at different stages of the build,
and make can't distinguish that. The solution here is that the first jade run
produces HTML.index, but does not require bookindex.sgml at all, and produces
no other html output (the latter an idea from Alvaro). The second jade run
includes bookindex.sgml, but does not recreate HTML.index. That way, when you
change an sgml file, jade is run twice and at the end all dependencies are
satisfied. Omitting the html output in the first stage also makes the full
build a lot faster.
When you run one of the print format targets, only the first jade run is run,
then the print target-specific commands. If an HTML build has completed
previously, the first jade run is skipped because the dependencies have
already been satisfied.
The draft and check targets for quick builds and syntax verification are still
there.
Modified Files:
--------------
pgsql/doc/src/sgml:
Makefile (r1.117 -> r1.118)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/Makefile?r1=1.117&r2=1.118)
filelist.sgml (r1.61 -> r1.62)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/filelist.sgml?r1=1.61&r2=1.62)
postgres.sgml (r1.88 -> r1.89)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/postgres.sgml?r1=1.88&r2=1.89)
stylesheet.dsl (r1.33 -> r1.34)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/stylesheet.dsl?r1=1.33&r2=1.34)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix EXPLAIN output for subplans in MERGE.
@ 2024-03-17 10:23 Dean Rasheed <dean.a.rasheed@gmail.com>
0 siblings, 0 replies; 4+ messages in thread
From: Dean Rasheed @ 2024-03-17 10:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix EXPLAIN output for subplans in MERGE.
Given a subplan in a MERGE query, EXPLAIN would sometimes fail to
properly display expressions involving Params referencing variables in
other parts of the plan tree.
This would affect subplans outside the topmost join plan node, for
which expansion of Params would go via the top-level ModifyTable plan
node. The problem was that "inner_tlist" for the ModifyTable node's
deparse_namespace was set to the join node's targetlist, but
"inner_plan" was set to the ModifyTable node itself, rather than the
join node, leading to incorrect results when descending to the
referenced variable.
Fix and backpatch to v15, where MERGE was introduced.
Discussion: https://postgr.es/m/CAEZATCWAv-sZuH%2BwG5xJ-%2BGt7qGNGX8wUQd3XYydMFDKgRB9nw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/33e729c5148c3a697abc552621b34bdc5fd497ed
Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 21 +++++++++-------
src/test/regress/expected/merge.out | 50 +++++++++++++++++++++++++++++++++++++
src/test/regress/sql/merge.sql | 17 +++++++++++++
3 files changed, 79 insertions(+), 9 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix EXPLAIN output for subplans in MERGE.
@ 2024-03-17 10:23 Dean Rasheed <dean.a.rasheed@gmail.com>
0 siblings, 0 replies; 4+ messages in thread
From: Dean Rasheed @ 2024-03-17 10:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix EXPLAIN output for subplans in MERGE.
Given a subplan in a MERGE query, EXPLAIN would sometimes fail to
properly display expressions involving Params referencing variables in
other parts of the plan tree.
This would affect subplans outside the topmost join plan node, for
which expansion of Params would go via the top-level ModifyTable plan
node. The problem was that "inner_tlist" for the ModifyTable node's
deparse_namespace was set to the join node's targetlist, but
"inner_plan" was set to the ModifyTable node itself, rather than the
join node, leading to incorrect results when descending to the
referenced variable.
Fix and backpatch to v15, where MERGE was introduced.
Discussion: https://postgr.es/m/CAEZATCWAv-sZuH%2BwG5xJ-%2BGt7qGNGX8wUQd3XYydMFDKgRB9nw%40mail.gmail.com
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/34c854b93fbec6d7b6dce4ee48c5b7459364a124
Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 21 +++++++++-------
src/test/regress/expected/merge.out | 50 +++++++++++++++++++++++++++++++++++++
src/test/regress/sql/merge.sql | 17 +++++++++++++
3 files changed, 79 insertions(+), 9 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix EXPLAIN output for subplans in MERGE.
@ 2024-03-17 10:23 Dean Rasheed <dean.a.rasheed@gmail.com>
0 siblings, 0 replies; 4+ messages in thread
From: Dean Rasheed @ 2024-03-17 10:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix EXPLAIN output for subplans in MERGE.
Given a subplan in a MERGE query, EXPLAIN would sometimes fail to
properly display expressions involving Params referencing variables in
other parts of the plan tree.
This would affect subplans outside the topmost join plan node, for
which expansion of Params would go via the top-level ModifyTable plan
node. The problem was that "inner_tlist" for the ModifyTable node's
deparse_namespace was set to the join node's targetlist, but
"inner_plan" was set to the ModifyTable node itself, rather than the
join node, leading to incorrect results when descending to the
referenced variable.
Fix and backpatch to v15, where MERGE was introduced.
Discussion: https://postgr.es/m/CAEZATCWAv-sZuH%2BwG5xJ-%2BGt7qGNGX8wUQd3XYydMFDKgRB9nw%40mail.gmail.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/89ee14a2f22b2353a6cf9d193c54504b4d3131f5
Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 21 +++++++++-------
src/test/regress/expected/merge.out | 50 +++++++++++++++++++++++++++++++++++++
src/test/regress/sql/merge.sql | 17 +++++++++++++
3 files changed, 79 insertions(+), 9 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-03-17 10:23 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-14 22:16 pgsql: Rearrangement of the HTML docs build rules Set up proper Peter Eisentraut <petere@postgresql.org>
2024-03-17 10:23 pgsql: Fix EXPLAIN output for subplans in MERGE. Dean Rasheed <dean.a.rasheed@gmail.com>
2024-03-17 10:23 pgsql: Fix EXPLAIN output for subplans in MERGE. Dean Rasheed <dean.a.rasheed@gmail.com>
2024-03-17 10:23 pgsql: Fix EXPLAIN output for subplans in MERGE. Dean Rasheed <dean.a.rasheed@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox