pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Make backend header files C++ safe This alters various
2+ messages / 2 participants
[nested] [flat]
* pgsql: Make backend header files C++ safe This alters various
@ 2009-07-16 06:33 Peter Eisentraut <petere@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: petere@postgresql.org @ 2009-07-16 06:33 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Make backend header files C++ safe
This alters various incidental uses of C++ key words to use other similar
identifiers, so that a C++ compiler won't choke outright. You still
(probably) need extern "C" { }; around the inclusion of backend headers.
based on a patch by Kurt Harriman <harriman@acm.org>
Also add a script cpluspluscheck to check for C++ compatibility in the
future. As of right now, this passes without error for me.
Modified Files:
--------------
pgsql/src/backend/access/common:
tupdesc.c (r1.126 -> r1.127)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/common/tupdesc.c?r1=1.126&r2=1...)
pgsql/src/backend/catalog:
pg_constraint.c (r1.45 -> r1.46)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/pg_constraint.c?r1=1.45&r2=1....)
pgsql/src/backend/commands:
indexcmds.c (r1.185 -> r1.186)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/indexcmds.c?r1=1.185&r2=1.18...)
sequence.c (r1.160 -> r1.161)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/sequence.c?r1=1.160&r2=1.161)
tablecmds.c (r1.289 -> r1.290)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.289&r2=1.29...)
typecmds.c (r1.134 -> r1.135)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/typecmds.c?r1=1.134&r2=1.135)
view.c (r1.116 -> r1.117)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/view.c?r1=1.116&r2=1.117)
pgsql/src/backend/nodes:
copyfuncs.c (r1.432 -> r1.433)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c?r1=1.432&r2=1.433)
equalfuncs.c (r1.355 -> r1.356)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c?r1=1.355&r2=1.356)
makefuncs.c (r1.64 -> r1.65)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/makefuncs.c?r1=1.64&r2=1.65)
nodeFuncs.c (r1.40 -> r1.41)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/nodeFuncs.c?r1=1.40&r2=1.41)
outfuncs.c (r1.360 -> r1.361)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/outfuncs.c?r1=1.360&r2=1.361)
readfuncs.c (r1.222 -> r1.223)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/readfuncs.c?r1=1.222&r2=1.223)
pgsql/src/backend/optimizer/plan:
subselect.c (r1.151 -> r1.152)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/subselect.c?r1=1.151&r...)
pgsql/src/backend/optimizer/util:
plancat.c (r1.158 -> r1.159)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/plancat.c?r1=1.158&r2=...)
pgsql/src/backend/parser:
gram.y (r2.669 -> r2.670)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/gram.y?r1=2.669&r2=2.670)
parse_clause.c (r1.189 -> r1.190)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_clause.c?r1=1.189&r2=1.1...)
parse_expr.c (r1.241 -> r1.242)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_expr.c?r1=1.241&r2=1.242)
parse_relation.c (r1.142 -> r1.143)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_relation.c?r1=1.142&r2=1...)
parse_target.c (r1.171 -> r1.172)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_target.c?r1=1.171&r2=1.1...)
parse_type.c (r1.103 -> r1.104)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_type.c?r1=1.103&r2=1.104)
parse_utilcmd.c (r2.22 -> r2.23)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_utilcmd.c?r1=2.22&r2=2.2...)
pgsql/src/backend/tcop:
utility.c (r1.309 -> r1.310)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/utility.c?r1=1.309&r2=1.310)
pgsql/src/backend/tsearch:
dict_thesaurus.c (r1.13 -> r1.14)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/dict_thesaurus.c?r1=1.13&r2=1...)
ts_parse.c (r1.12 -> r1.13)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/ts_parse.c?r1=1.12&r2=1.13)
ts_selfuncs.c (r1.4 -> r1.5)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/ts_selfuncs.c?r1=1.4&r2=1.5)
wparser_def.c (r1.23 -> r1.24)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/wparser_def.c?r1=1.23&r2=1.24)
pgsql/src/backend/utils/adt:
ruleutils.c (r1.302 -> r1.303)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c?r1=1.302&r2=1.3...)
tsginidx.c (r1.16 -> r1.17)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsginidx.c?r1=1.16&r2=1.17)
tsquery.c (r1.20 -> r1.21)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsquery.c?r1=1.20&r2=1.21)
tsquery_cleanup.c (r1.11 -> r1.12)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsquery_cleanup.c?r1=1.11&r...)
tsquery_op.c (r1.6 -> r1.7)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsquery_op.c?r1=1.6&r2=1.7)
tsquery_rewrite.c (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsquery_rewrite.c?r1=1.14&r...)
tsquery_util.c (r1.11 -> r1.12)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsquery_util.c?r1=1.11&r2=1...)
tsrank.c (r1.15 -> r1.16)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsrank.c?r1=1.15&r2=1.16)
tsvector_op.c (r1.23 -> r1.24)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/tsvector_op.c?r1=1.23&r2=1....)
pgsql/src/backend/utils/misc:
guc.c (r1.506 -> r1.507)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.506&r2=1.507)
pgsql/src/backend/utils/mmgr:
mcxt.c (r1.66 -> r1.67)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mmgr/mcxt.c?r1=1.66&r2=1.67)
pgsql/src/include/catalog:
pg_constraint.h (r1.30 -> r1.31)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_constraint.h?r1=1.30&r2=1....)
pgsql/src/include/commands:
defrem.h (r1.94 -> r1.95)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/defrem.h?r1=1.94&r2=1.95)
tablecmds.h (r1.43 -> r1.44)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/tablecmds.h?r1=1.43&r2=1.44)
pgsql/src/include/nodes:
makefuncs.h (r1.68 -> r1.69)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/makefuncs.h?r1=1.68&r2=1.69)
memnodes.h (r1.35 -> r1.36)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/memnodes.h?r1=1.35&r2=1.36)
parsenodes.h (r1.395 -> r1.396)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/parsenodes.h?r1=1.395&r2=1.396)
primnodes.h (r1.149 -> r1.150)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/primnodes.h?r1=1.149&r2=1.150)
pgsql/src/include/optimizer:
plancat.h (r1.54 -> r1.55)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/optimizer/plancat.h?r1=1.54&r2=1.55)
pgsql/src/include/parser:
parse_type.h (r1.40 -> r1.41)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/parser/parse_type.h?r1=1.40&r2=1.41)
pgsql/src/include/tsearch:
ts_public.h (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/tsearch/ts_public.h?r1=1.14&r2=1.15)
ts_type.h (r1.15 -> r1.16)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/tsearch/ts_type.h?r1=1.15&r2=1.16)
ts_utils.h (r1.17 -> r1.18)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/tsearch/ts_utils.h?r1=1.17&r2=1.18)
pgsql/src/include/utils:
builtins.h (r1.333 -> r1.334)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/builtins.h?r1=1.333&r2=1.334)
Added Files:
-----------
pgsql/src/tools/pginclude:
cpluspluscheck (r1.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/pginclude/cpluspluscheck?rev=1.1&conten...)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Generalize handling of nullable pg_attribute columns in DDL
@ 2024-03-17 11:53 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 2+ messages in thread
From: Peter Eisentraut @ 2024-03-17 11:53 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Generalize handling of nullable pg_attribute columns in DDL
DDL code uses tuple descriptors to pass around pg_attribute values
during table and index creation. But tuple descriptors don't include
the variable-length/nullable columns of pg_attribute, so they have to
be handled separately. Right now, the attoptions field is handled in
a one-off way with a separate argument passed to
InsertPgAttributeTuples(). The other affected fields of pg_attribute
are right now not needed at relation creation time.
The goal of this patch is to generalize this to allow handling
additional variable-length/nullable columns of pg_attribute in a
similar manner. For that, create a new struct
FormExtraData_pg_attribute, which is to be passed around in parallel
to the tuple descriptor and optionally supplies the additional
columns. Right now, this struct only contains one field for
attoptions, so no functionality is actually changed by this.
Reviewed-by: Tomas Vondra <tomas.vondra@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/flat/4da8d211-d54d-44b9-9847-f2a9f1184c76@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d939cb2fd612acde0304913213cfbdb01994e682
Modified Files
--------------
src/backend/catalog/heap.c | 21 ++++++++++++++-------
src/backend/catalog/index.c | 16 +++++++++++++++-
src/include/catalog/heap.h | 2 +-
src/include/catalog/pg_attribute.h | 13 +++++++++++++
src/tools/pgindent/typedefs.list | 1 +
5 files changed, 44 insertions(+), 9 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-03-17 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-16 06:33 pgsql: Make backend header files C++ safe This alters various Peter Eisentraut <petere@postgresql.org>
2024-03-17 11:53 pgsql: Generalize handling of nullable pg_attribute columns in DDL Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox