pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Tweak TOAST code so that columns marked with MAIN storage
4+ messages / 2 participants
[nested] [flat]
* pgsql: Tweak TOAST code so that columns marked with MAIN storage
@ 2009-07-22 01:21 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: tgl@postgresql.org @ 2009-07-22 01:21 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Tweak TOAST code so that columns marked with MAIN storage strategy are
not forced out-of-line unless that is necessary to make the row fit on a
page. Previously, they were forced out-of-line if needed to get the row
down to the default target size (1/4th page).
Kevin Grittner
Modified Files:
--------------
pgsql/doc/src/sgml:
storage.sgml (r1.29 -> r1.30)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/storage.sgml?r1=1.29&r2=1.30)
pgsql/src/backend/access/heap:
tuptoaster.c (r1.93 -> r1.94)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/heap/tuptoaster.c?r1=1.93&r2=1...)
pgsql/src/include/access:
tuptoaster.h (r1.43 -> r1.44)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/tuptoaster.h?r1=1.43&r2=1.44)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix query result leak during binary upgrade
@ 2024-05-15 20:52 Daniel Gustafsson <dgustafsson@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Gustafsson @ 2024-05-15 20:52 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix query result leak during binary upgrade
9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional. 353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/374550C1-F4ED-4D9D-9498-0FD029CCF674@yesql.se
Backpatch-through: v15
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a8f87d5d21c2f3ddd644c9cb313ecd43290a446e
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix query result leak during binary upgrade
@ 2024-05-15 20:53 Daniel Gustafsson <dgustafsson@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Gustafsson @ 2024-05-15 20:53 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix query result leak during binary upgrade
9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional. 353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/374550C1-F4ED-4D9D-9498-0FD029CCF674@yesql.se
Backpatch-through: v15
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0ae05c18e0bf740e6457e710f9323e75f6619c35
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix query result leak during binary upgrade
@ 2024-05-15 20:54 Daniel Gustafsson <dgustafsson@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Gustafsson @ 2024-05-15 20:54 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix query result leak during binary upgrade
9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional. 353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/374550C1-F4ED-4D9D-9498-0FD029CCF674@yesql.se
Backpatch-through: v15
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e6fc3b70df906868df36517c2c7c5a38725e1451
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-05-15 20:54 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-22 01:21 pgsql: Tweak TOAST code so that columns marked with MAIN storage Tom Lane <tgl@postgresql.org>
2024-05-15 20:52 pgsql: Fix query result leak during binary upgrade Daniel Gustafsson <dgustafsson@postgresql.org>
2024-05-15 20:53 pgsql: Fix query result leak during binary upgrade Daniel Gustafsson <dgustafsson@postgresql.org>
2024-05-15 20:54 pgsql: Fix query result leak during binary upgrade Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox