Date: Tue, 6 May 2014 17:52:59 +0200
From: Andres Freund <andres@2ndquadrant.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Properly detect read and write errors in
 pg_dump/dumpall, and pg
Message-ID: <20140506155259.GC5658@awork2.anarazel.de>
References: <E1WhTE9-0002Q2-U0@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <E1WhTE9-0002Q2-U0@gemulon.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

On 2014-05-06 00:27:21 +0000, Bruce Momjian wrote:
> Properly detect read and write errors in pg_dump/dumpall, and pg_restore
>=20
> Previously some I/O errors were ignored.

My compiler complains about this with:

/home/andres/src/postgresql/src/bin/pg_dump/pg_backup_tar.c: In function =
=E2=80=98_tarReadRaw=E2=80=99:
/home/andres/src/postgresql/src/bin/pg_dump/pg_backup_archiver.h:48:19: war=
ning: passing argument 1 of =E2=80=98gzeof=E2=80=99 from incompatible point=
er type
 #define GZEOF(fh) gzeof(fh)
                   ^
/home/andres/src/postgresql/src/bin/pg_dump/pg_backup_tar.c:561:24: note: i=
n expansion of macro =E2=80=98GZEOF=E2=80=99
     if (res !=3D len && !GZEOF(fh))
                        ^
In file included from /home/andres/src/postgresql/src/bin/pg_dump/pg_backup=
_archiver.h:44:0,
                 from /home/andres/src/postgresql/src/bin/pg_dump/pg_backup=
_tar.c:32:
/usr/include/zlib.h:1475:21: note: expected =E2=80=98gzFile=E2=80=99 but ar=
gument is of type =E2=80=98struct FILE *=E2=80=99
 ZEXTERN int ZEXPORT gzeof OF((gzFile file));
                     ^
You're passing fh to GZEOF instead of th->zFH if I see that correctly.

Greetings,

Andres Freund

--=20
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


--=20
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers