Date: Tue, 6 May 2014 12:21:20 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Andres Freund <andres@2ndquadrant.com>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Properly detect read and write errors in
 pg_dump/dumpall, and pg
Message-ID: <20140506162120.GD30817@momjian.us>
References: <E1WhTE9-0002Q2-U0@gemulon.postgresql.org>
 <20140506155259.GC5658@awork2.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20140506155259.GC5658@awork2.anarazel.de>
User-Agent: Mutt/1.5.20 (2009-06-14)
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

On Tue, May  6, 2014 at 05:52:59PM +0200, Andres Freund wrote:
> On 2014-05-06 00:27:21 +0000, Bruce Momjian wrote:
> > Properly detect read and write errors in pg_dump/dumpall, and pg_restore
> > 
> > Previously some I/O errors were ignored.
> 
> My compiler complains about this with:
> 
> /home/andres/src/postgresql/src/bin/pg_dump/pg_backup_tar.c: In function ‘_tarReadRaw’:
> /home/andres/src/postgresql/src/bin/pg_dump/pg_backup_archiver.h:48:19: warning: passing argument 1 of ‘gzeof’ from incompatible pointer type
>  #define GZEOF(fh) gzeof(fh)
>                    ^
> /home/andres/src/postgresql/src/bin/pg_dump/pg_backup_tar.c:561:24: note: in expansion of macro ‘GZEOF’
>      if (res != len && !GZEOF(fh))
>                         ^
> In file included from /home/andres/src/postgresql/src/bin/pg_dump/pg_backup_archiver.h:44:0,
>                  from /home/andres/src/postgresql/src/bin/pg_dump/pg_backup_tar.c:32:
> /usr/include/zlib.h:1475:21: note: expected ‘gzFile’ but argument is of type ‘struct FILE *’
>  ZEXTERN int ZEXPORT gzeof OF((gzFile file));
>                      ^
> You're passing fh to GZEOF instead of th->zFH if I see that correctly.

There were a few bugs, all fixed.  Thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers