Date: Mon, 13 Apr 2015 14:17:05 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>, Fujii Masao <fujii@postgresql.org>,
 pgsql-committers@postgresql.org
Subject: Re: pgsql: Mark the second argument of pg_log as the
 translatable string in
Message-ID: <20150413171705.GQ4369@alvh.no-ip.org>
References: <E1YffOB-0006ry-RI@gemulon.postgresql.org>
 <5529C5A7.3070708@gmx.net> <20150412011715.GK4369@alvh.no-ip.org>
 <CAB7nPqQP8NU3WztTG8Snd4k2S5dLx1CN0dRCzcuFF1GuyqJATQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAB7nPqQP8NU3WztTG8Snd4k2S5dLx1CN0dRCzcuFF1GuyqJATQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

Michael Paquier wrote:
> On Sun, Apr 12, 2015 at 10:17 AM, Alvaro Herrera wrote:
> > What pg_basebackup's progress_report() does is have the message in the
> > translatable part not include the \r; the \r is in a separate fprintf()
> > call.
> 
> Like the attached then.

Not a fan of this approach, because now this function knows that
pg_log(PG_PROGRESS) is equivalent to printf().  This abstraction is a
bit leaky, isn't it ...  Probably not worth sweating about, though.

> diff --git a/src/bin/pg_rewind/logging.c b/src/bin/pg_rewind/logging.c
> index aba12d8..3e2dc76 100644
> --- a/src/bin/pg_rewind/logging.c
> +++ b/src/bin/pg_rewind/logging.c
> @@ -134,7 +134,8 @@ progress_report(bool force)
>  	snprintf(fetch_size_str, sizeof(fetch_size_str), INT64_FORMAT,
>  			 fetch_size / 1024);
>  
> -	pg_log(PG_PROGRESS, "%*s/%s kB (%d%%) copied\r",
> +	pg_log(PG_PROGRESS, "%*s/%s kB (%d%%) copied",
>  		   (int) strlen(fetch_size_str), fetch_done_str, fetch_size_str,
>  		   percent);
> +	printf("\r");
>  }


-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers