Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZH7KT-0007AR-Kz for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jul 2015 09:25:45 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZH7KT-0003Za-7E for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jul 2015 09:25:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZH7KM-0003Sq-Bl for pgsql-hackers@postgresql.org; Mon, 20 Jul 2015 09:25:38 +0000 Received: from smtp-auth.no-ip.com ([8.23.224.61] helo=out.smtp-auth.no-ip.com) by magus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZH7KC-0001Vz-EK for pgsql-hackers@postgresql.org; Mon, 20 Jul 2015 09:25:37 +0000 X-No-IP: alvh.no-ip.org@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from alvin.alvh.no-ip.org (unknown [89.176.99.192]) (Authenticated sender: alvh.no-ip.org@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id AE843400927; Mon, 20 Jul 2015 02:25:20 -0700 (PDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 3AC72117C; Mon, 20 Jul 2015 13:25:17 +0400 (SAMT) Date: Mon, 20 Jul 2015 11:25:17 +0200 From: Alvaro Herrera To: Heikki Linnakangas Cc: Michael Paquier , Kevin Grittner , "pgsql-hackers@postgresql.org" Subject: Re: Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY Message-ID: <20150720092517.GH2301@postgresql.org> References: <81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com> <55A94C2D.1010204@iki.fi> <20150718131528.GV2301@postgresql.org> <55ACA793.7080400@iki.fi> <20150720084146.GF2301@postgresql.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150720084146.GF2301@postgresql.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Alvaro Herrera wrote: > Heikki Linnakangas wrote: > > On 07/18/2015 04:15 PM, Alvaro Herrera wrote: > > >Heikki Linnakangas wrote: > > >>If it's there just to so you can run the regression tests that come > > >>with it, it might make sense to just add a "default" case to that > > >>switch to handle any unrecognized commands, and perhaps even remove > > >>the cases for the currently untested subcommands as it's just dead > > >>code. > > > > > >Well, I would prefer to have an output that says "unrecognized" and then > > >add more test cases to the SQL files so that there's not so much dead > > >code. I prefer that to removing the C support code, because then as > > >we add extra tests we don't need to modify the C source. > > > > Ok. I added a case for AT_ReAddComment, and also a default-case that says > > "unrecognized". > > Oh, sorry, I forgot to tell you that I was working on it. I pushed the remaining part of my patch. Thanks for fixing the other bits. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers