Date: Mon, 20 Jul 2015 11:46:47 +0200
From: Andres Freund <andres@anarazel.de>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Michael Paquier <michael.paquier@gmail.com>,
 Kevin Grittner <kgrittn@ymail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: Re: [COMMITTERS] pgsql: Retain comments on indexes and
 constraints at ALTER TABLE ... TY
Message-ID: <20150720094647.GX5520@alap3.anarazel.de>
References: <E1ZEvoc-0002RV-Vh@gemulon.postgresql.org>
 <81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com>
 <CAB7nPqTnAyTwrnXfyJdmovu0B991KK3tymgW5NNtPWyU=fhNzQ@mail.gmail.com>
 <55A94C2D.1010204@iki.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55A94C2D.1010204@iki.fi>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2015-07-17 21:40:45 +0300, Heikki Linnakangas wrote:
> Hmm, that function is pretty fragile, it will segfault on any AT_* type that
> it doesn't recognize. Thankfully you get that compiler warning, but we have
> added AT_* type codes before in minor releases.

For in-core code that is supposed to handle all cases I find it much
better to get a compiler warning than to error out in a default:
case. The latter is very likely not going to be exercised by any test
and thus not be noticed for prolonged time.

Might make sense to test for -Werror=switch and add that to the compiler
flags by default.

Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers