Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akb5L-0006j4-MA for pgsql-committers@arkaria.postgresql.org; Mon, 28 Mar 2016 17:36:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1akb5K-0001Q7-L3 for pgsql-committers@arkaria.postgresql.org; Mon, 28 Mar 2016 17:36:14 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1akb58-0001CW-F4 for pgsql-committers@postgresql.org; Mon, 28 Mar 2016 17:36:02 +0000 Received: from tamriel.snowman.net ([2001:4830:167b::11]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akb55-0003EI-Cl for pgsql-committers@postgresql.org; Mon, 28 Mar 2016 17:36:01 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id A05315F798; Mon, 28 Mar 2016 13:35:58 -0400 (EDT) Date: Mon, 28 Mar 2016 13:35:58 -0400 From: Stephen Frost To: Alvaro Herrera Cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Improve internationalization of messages involving type names Message-ID: <20160328173558.GU3127@tamriel.snowman.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4A79KfPqnT9qCbac" Content-Disposition: inline In-Reply-To: X-Editor: Vim http://www.vim.org/ X-Info: http://www.snowman.net X-Operating-System: Linux/3.13.0-77-generic (x86_64) X-Uptime: 13:35:22 up 34 days, 14:28, 9 users, load average: 0.25, 0.14, 0.08 User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -2.9 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org --4A79KfPqnT9qCbac Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Alvaro, * Alvaro Herrera (alvherre@alvh.no-ip.org) wrote: > Improve internationalization of messages involving type names >=20 > Change the slightly different variations of the message > function FOO must return type BAR > to a single wording, removing the variability in type name so that they > all create a single translation entry; since the type name is not to be > translated, there's no point in it being part of the message anyway. >=20 > Also, change them all to use the same quoting convention, namely that > the function name is not to be quoted but the type name is. (I'm not > quite sure why this is so, but it's the clear majority.) >=20 > Some similar messages such as "encoding conversion function FOO must ..." > are also changed. Buildfarm is pretty upset with this one, in particular: http://git.postgresql.org/gitweb/?p=3Dpostgresql.git;a=3Dblobdiff;f=3Dsrc/b= ackend/commands/event_trigger.c;h=3D3735d44ee9d0b89f35ca8e8fb00b1a8dbbaa636= 2;hp=3D3f52ad836b4a2be1d95047f0949607d8cbbb283d;hb=3D59a2111;hpb=3D559e7a0a= 6d4450c09825055e3d255d30ee869c67 Thanks! Stephen --4A79KfPqnT9qCbac Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJW+Wt+AAoJEO1sijiDR2RVJJgP/36iUBLoZc2rWqrik2vZmQEi h7/LpfUywWfspzBnGWcvEq3HAfTQJgMGUW64S+g1+zQ8ykcd7668xZNIwlzIW6Pt 0So4c5ERjzRh+GbK/jiLwGQHaIGlFchYE1HBm2a8EPZU8hiQB4+YXJ+PUu6ortU7 GzKChpHpdYQc3jgKfX6xzoZRAmYUjU4n/r5xUp3XGci0buckiWlfO0ibdFWQtRlS CyOHrY3Ga6YjRsehpEUr52ODm2i3KN0LFoaBIpHz1nxX2j1keauma0HG1hqAET4m S4uCF91C7boeINNmU6HZbboU3ZHim77JYtCenitj6850c7pDXT8ubmBurwGHNEvv ONG/ASJ+Z6+cJF4sv+cHl2tQwLajcfDje8hYMLJklY5meHX6coHF1hpwDAQ2vbed Od9gg0JPRDI2xi72rBskwY/CR4YbpkTq8FkOgpEa8Cyw4YNOSPxrWtglt5P5L/Yx MUYiWcL2rB0Gk1rQimha9WPyy8/5b9U6F4ypwhLkATRG6b9vDwJKpCuFYsQRzuUU /JtxXxMlLCKUGfcqXt3mXhOiuYElzo4/jS5CKvbLTUFaifmVANUOamexQdIz3602 bcxT2H7rEZKqNQdrioKYrI8m4TuA6TTbejc8NsbYSoyq+x7juKbJK2hV9rfiIg3n k9d4EkesFoddC/0Q+tfU =lxEf -----END PGP SIGNATURE----- --4A79KfPqnT9qCbac--