Date: Wed, 30 Mar 2016 18:43:54 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Improve internationalization of messages
 involving type names
Message-ID: <20160330214354.GA48283@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <10551.1459188367@sss.pgh.pa.us>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Also, change them all to use the same quoting convention, namely that
> > the function name is not to be quoted but the type name is.  (I'm not
> > quite sure why this is so, but it's the clear majority.)
> 
> Actually, I think the general convention is to NOT quote type names
> in error messages.  Certainly that's so when using format_type_be()
> to produce a name for a not-known-at-compile-time type.  I would
> argue that these messages should be written to look the same as if
> format_type_be() had been used, and that would mean leaving off
> the quotes.

Ok, I'll change it.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers