Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1am25G-000075-Go for pgsql-committers@arkaria.postgresql.org; Fri, 01 Apr 2016 16:38:06 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1am25G-0006yA-3L for pgsql-committers@arkaria.postgresql.org; Fri, 01 Apr 2016 16:38:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1am253-0006kc-TO for pgsql-committers@postgresql.org; Fri, 01 Apr 2016 16:37:53 +0000 Received: from smtp-auth.no-ip.com ([8.23.224.61] helo=out.smtp-auth.no-ip.com) by magus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1am24z-0007KV-M2 for pgsql-committers@postgresql.org; Fri, 01 Apr 2016 16:37:53 +0000 X-No-IP: alvh.no-ip.org@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from alvin.alvh.no-ip.org (unknown [200.83.202.40]) (Authenticated sender: alvh.no-ip.org@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id BD0A4400ECE; Fri, 1 Apr 2016 09:37:41 -0700 (PDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id ACDEA6C4; Fri, 1 Apr 2016 13:37:39 -0300 (CLT) Date: Fri, 1 Apr 2016 13:37:39 -0300 From: Alvaro Herrera To: Tom Lane Cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Improve internationalization of messages involving type names Message-ID: <20160401163739.GA41982@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160330214354.GA48283@alvherre.pgsql> User-Agent: Mutt/1.5.23 (2014-03-12) X-Pg-Spam-Score: -1.1 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org Alvaro Herrera wrote: > Tom Lane wrote: > > Actually, I think the general convention is to NOT quote type names > > in error messages. Certainly that's so when using format_type_be() > > to produce a name for a not-known-at-compile-time type. I would > > argue that these messages should be written to look the same as if > > format_type_be() had been used, and that would mean leaving off > > the quotes. > > Ok, I'll change it. Done. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers