Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5bGu-0006DX-8z for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Nov 2016 16:35:16 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1c5bGt-0003th-Rn for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Nov 2016 16:35:15 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c5bGt-0003tH-64 for pgsql-hackers@postgresql.org; Sat, 12 Nov 2016 16:35:15 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c5bGp-0002l2-Do for pgsql-hackers@postgresql.org; Sat, 12 Nov 2016 16:35:14 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C9C16205E4; Sat, 12 Nov 2016 11:35:10 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Sat, 12 Nov 2016 11:35:10 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=vvBH+tdd6FfjH4 IM8bqmiRybAeY=; b=gpyyXLzrDbPyP1xwrtl5k0+YLxQP0XL4aN4P3YYdqc+ZCc E6f0ImKqBHj4flqgoW12imIsQr4L3t6rnR2fpoE6xGxzlZl9glc6Kk3HJT7iQkXN zUSmFKrUHjabKfKdP3N++ajBJAjVojYVQwph7u5MOvJXWx12ANV7j1J11I5ww= X-ME-Sender: X-Sasl-enc: zjtrn/H1lCIRMUGAqB0aM2SJfbxyr1hWnUcbut9HojOd 1478968510 Received: from intern.anarazel.de (unknown [88.128.80.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 762DE7F086; Sat, 12 Nov 2016 11:35:10 -0500 (EST) Date: Sat, 12 Nov 2016 08:35:08 -0800 From: Andres Freund To: Tom Lane Cc: Amit Kapila , Ashutosh Sharma , Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. Message-ID: <20161112163508.5uqlaozeyr3l56ae@alap3.anarazel.de> References: <20160826220026.2fw6xj56qgd22wqi@alap3.anarazel.de> <20160830023140.tsesenk7roajx3ak@alap3.anarazel.de> <20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de> <22432.1478968242@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22432.1478968242@sss.pgh.pa.us> X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 2016-11-12 11:30:42 -0500, Tom Lane wrote: > Andres Freund writes: > > Committed after simplifying the Makefile. > > While I have no particular objection to adding these tests, the > commit log's claim that this will improve buildfarm testing is > quite wrong. The buildfarm runs "make installcheck" not > "make check" in contrib. Gah. It was more aimed at the coverage stuff, but that might work the same. Alvaro? > which is a rather blatant waste of cycles. I would suggest an explicit > do-nothing installcheck rule rather than the hack you came up with here. I had that at first, but that generates a warning about overwriting the makefile target - which afaics cannot be fixed. Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers