Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5bsT-0007d0-G2 for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Nov 2016 17:14:05 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1c5bsR-0000mK-NY for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Nov 2016 17:14:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c5br1-0007ei-5C for pgsql-hackers@postgresql.org; Sat, 12 Nov 2016 17:12:35 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c5bqx-0008VA-GM for pgsql-hackers@postgresql.org; Sat, 12 Nov 2016 17:12:34 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7B3B620571; Sat, 12 Nov 2016 12:12:29 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 12 Nov 2016 12:12:29 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=9nBFLSePx92T81 qyePtqBf6jcAY=; b=SmVXoB0oCpqZtQWDB+xaqA/ZFnPFqs8XcoZFZOufO31C+0 J3/Ud+PStnycfKg2MV65YPfFuYNIFEiSgwUEJQdKRYye+ILVkZqvwyGLVjuAVqn/ CZqvHsdSkC2VgB2BkBmADWNvkcBdYQ/SZBkrEoOLceiBCnE+U0nmucJOlebM8= X-ME-Sender: X-Sasl-enc: kD/FdnaNK1gQU3v4aiEViPy04iK/m9s/6GP7hELZ0keS 1478970748 Received: from intern.anarazel.de (unknown [172.56.12.4]) by mail.messagingengine.com (Postfix) with ESMTPA id D02492506D; Sat, 12 Nov 2016 12:12:28 -0500 (EST) Date: Sat, 12 Nov 2016 09:12:25 -0800 From: Andres Freund To: Tom Lane Cc: Amit Kapila , Ashutosh Sharma , Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. Message-ID: <20161112171225.eo5vm7cjfatufm6q@alap3.anarazel.de> References: <20160830023140.tsesenk7roajx3ak@alap3.anarazel.de> <20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de> <22432.1478968242@sss.pgh.pa.us> <20161112163508.5uqlaozeyr3l56ae@alap3.anarazel.de> <22899.1478968932@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22899.1478968932@sss.pgh.pa.us> X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 2016-11-12 11:42:12 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2016-11-12 11:30:42 -0500, Tom Lane wrote: > >> which is a rather blatant waste of cycles. I would suggest an explicit > >> do-nothing installcheck rule rather than the hack you came up with here. > > > I had that at first, but that generates a warning about overwriting the > > makefile target - which afaics cannot be fixed. > > Hm. What about inventing an additional macro NO_INSTALLCHECK that > prevents pgxs.mk from generating an installcheck rule? That'd work. I'd also be ok with living with the warning. I have to say I find it hard to be concerned about the cycles here. It's not like anybody complained about make check unconditionally creating a test installation, even if there's tests in a contrib module... Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers