Date: Tue, 6 Dec 2016 00:38:03 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: [COMMITTERS] pgsql: Permit dump/reload of not-too-large >1GB
 tuples
Message-ID: <20161206033802.dklbbnrzfnx6ddhc@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <27737.1480993846@sss.pgh.pa.us>
User-Agent: NeoMutt/20161104 (1.7.1)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Permit dump/reload of not-too-large >1GB tuples
> 
> I apologize for not having paid close enough attention earlier, but:
> this patch is absolutely unacceptable for the back branches and MUST
> be reverted there.  Adding another field to StringInfoData is an ABI
> change that will certainly break large numbers of extensions.  We
> can't expect those to get recompiled for minor releases.

Oh, I see the problem now -- it can (and frequently is) stack allocated,
not just palloc'ed using the StringInfo api, and changing the size
breaks that.  Rats.  I'll revert tomorrow.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers