Date: Mon, 12 Dec 2016 16:46:48 -0800
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>,
	Peter Eisentraut <peter_e@gmx.net>, pgsql-committers@postgresql.org
Subject: Re: pgsql: Add support for temporary replication slots
Message-ID: <20161213004648.zww4z4rworue7kcg@alap3.anarazel.de>
References: <E1cGRP8-0003EH-So@gemulon.postgresql.org>
 <27274.1481557380@sss.pgh.pa.us>
 <27833.1481558144@sss.pgh.pa.us>
 <62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com>
 <22907.1481571177@sss.pgh.pa.us>
 <15713.1481585953@sss.pgh.pa.us>
 <314cae39-2e7d-f5a3-d226-cfb80cf80481@2ndquadrant.com>
 <18684.1481589637@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <18684.1481589637@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

On 2016-12-12 19:40:37 -0500, Tom Lane wrote:
> Petr Jelinek <petr.jelinek@2ndquadrant.com> writes:
> > Yes, I've seen. The cleanup of slots is done in ProcKill(), I wonder,
> > since it's on_shmem_exit hook, and the pgstat_beshutdown_hook is as
> > well, maybe the pgstat_beshutdown_hook is called before ProcKill and the
> > query is lucky to hit right in between.
> 
> Hm.  That seems like a pretty bogus place to do it.

Well, that'd not be Pet[e]r's fault. Robert and I had some preexisting
slot cleanpucode there (which I'd like to consolidate btw).

> backend infrastructure is already gone by then, if I recall the ordering
> correctly.  Maybe ShutdownPostgres would be a saner place; but it really
> depends on what you think the module layering is for this facility.
> I would definitely not think it is proc.c's responsibility, though.

Slots quite possibly can used by bgworkers, so I don't think
ShutdownPostgres would be right.  I don't think there's a perfect place
for it atm, so it's ProcKill()...

- Andres


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers