Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duMXf-0005nr-KI for pgsql-committers@arkaria.postgresql.org; Tue, 19 Sep 2017 17:42:39 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1duMXf-0002Ue-70 for pgsql-committers@arkaria.postgresql.org; Tue, 19 Sep 2017 17:42:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1duMXe-0002Sy-MG for pgsql-committers@postgresql.org; Tue, 19 Sep 2017 17:42:38 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1duMXb-0003zJ-Ui for pgsql-committers@postgresql.org; Tue, 19 Sep 2017 17:42:38 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5AECB215D4; Tue, 19 Sep 2017 13:42:34 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 19 Sep 2017 13:42:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=+Shitmr3P79Y+x3lyw TKOIuy2LSEhoTSC2d3HbXQsK8=; b=QOAkcsS38tu5n9pRBpXx1EAwt4E/kIm9He cvogwezwIK1EFqK5yYz0glhXZr7lENttsr4uGU+GktocI04i/yUwi4V6qY2GFJVd pIr+hjIn3QIZOSgfsulRffuxoBBF3drEJ5xki4tZ5wggCFNaokER7fvLs/YHQTWo xDQcUFGbt2/oTEwUAenBxMrpmeoF9RwAhq0HaYuuFvYGu2Oh+Ylq4QijgTUNbUWH S0f7wob/pK9P2dr/6dq4kEfHq9WcFp90wRfg//S9clKLaAcPM116jVir+7rtebTy ZBOx8LunvX8mCE/gTlz7//ihJjLIvKhgVR/nnbD7mXad+ii7Rtxw== X-ME-Sender: X-Sasl-enc: usWA/oLxvRRSuJ+k4J2xn4OLPTIRD27/toCQ4G/ORpAZ 1505842953 Received: from intern.anarazel.de (unknown [136.24.76.72]) by mail.messagingengine.com (Postfix) with ESMTPA id E1F7D7FA74; Tue, 19 Sep 2017 13:42:33 -0400 (EDT) Date: Tue, 19 Sep 2017 10:42:32 -0700 From: Andres Freund To: Tom Lane Cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Add test for postmaster crash restarts. Message-ID: <20170919174232.soc2skrqxxdtnh22@alap3.anarazel.de> References: <5250.1505793335@sss.pgh.pa.us> <8818AEBD-57F7-420D-8348-CDB426020BFE@anarazel.de> <17084.1505837634@sss.pgh.pa.us> <20170919164718.66hcedq2rtlkntvf@alap3.anarazel.de> <18695.1505840008@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On 2017-09-19 09:58:26 -0700, Andres Freund wrote: > > > On September 19, 2017 9:53:28 AM PDT, Tom Lane wrote: > >Well, please fix it ASAP, if you don't want to take it out pending > >the fixes. > > Will as soon as I finished my morning coffee. Uncaffeinated, which my phone fittingly autocorrects to unvaccinated, commits aren't a good idea. Done. Survived ~100 cycles here locally, while running make -j16 -s check-world in two parallel branches. But I have a fast disk, so it's not comparable. If the buildfarm doesn't complain about the use of IPC::Run's timeout functionality, we should probably patch that into the other use of IPC::Run as well, but especially into the other user of the pump() until ... scheme. Greetings, Andres Freund -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers