Date: Sat, 30 Sep 2017 15:27:12 -0700
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Add test for postmaster crash restarts.
Message-ID: <20170930222712.xgdgxnt4sjvig5mn@alap3.anarazel.de>
References: <8818AEBD-57F7-420D-8348-CDB426020BFE@anarazel.de>
 <17084.1505837634@sss.pgh.pa.us>
 <20170919164718.66hcedq2rtlkntvf@alap3.anarazel.de>
 <18695.1505840008@sss.pgh.pa.us>
 <D2FBABBF-F0E3-43FE-8EA4-E2431DD6EEBA@anarazel.de>
 <20170919174232.soc2skrqxxdtnh22@alap3.anarazel.de>
 <21486.1506601297@sss.pgh.pa.us>
 <5ce9b1f4-dff8-6fe9-74ab-d8e1b993b1d5@2ndQuadrant.com>
 <20170930221043.iay4s7rmwm5l7wiw@alap3.anarazel.de>
 <56b65da3-f7cc-494c-7952-ba5f6c804d7e@2ndQuadrant.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <56b65da3-f7cc-494c-7952-ba5f6c804d7e@2ndQuadrant.com>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

On 2017-09-30 18:21:33 -0400, Andrew Dunstan wrote:
> 
> [re-adding commiters which I inadvertently left off]
> 
> 
> On 09/30/2017 06:10 PM, Andres Freund wrote:
> >
> >
> >> I was just looking at this. Why aren't we using "pg_ctl kill" to
> >> terminate the backend? That's supposed to be portable.
> > Because pg_ctl can't do that for any process but postmaster, no? The
> > test is supposed to find issues with backend death (and has
> > defficiencies in error reporting already, and would have caught a bug
> > I'd introduced previously).

> No, I don't think so. That's not what the docs say. That's why you give
> it a pid argument" "pg_ctl kill signal_name process_id"

Oh, cool. Didn't know that one. So the answer is:
"Because Andres doesn't know squat.".

But even after fixing that, there unfortunately is:

static void
set_sig(char *signame)
{
…
#if 0
	/* probably should NOT provide SIGKILL */
	else if (strcmp(signame, "KILL") == 0)
		sig = SIGKILL;
#endif

I'm unclear on what that provision is achieving? If you can kill with
pg_ctl you can do other nasty stuff too (like just use kill instead of
pg_ctl)?

Greetings,

Andres Freund


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers