Date: Sat, 30 Sep 2017 19:32:14 -0700
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Add test for postmaster crash restarts.
Message-ID: <20171001023214.zgw3gs7mxjmlkqcd@alap3.anarazel.de>
References: <18695.1505840008@sss.pgh.pa.us>
 <D2FBABBF-F0E3-43FE-8EA4-E2431DD6EEBA@anarazel.de>
 <20170919174232.soc2skrqxxdtnh22@alap3.anarazel.de>
 <21486.1506601297@sss.pgh.pa.us>
 <5ce9b1f4-dff8-6fe9-74ab-d8e1b993b1d5@2ndQuadrant.com>
 <20170930221043.iay4s7rmwm5l7wiw@alap3.anarazel.de>
 <56b65da3-f7cc-494c-7952-ba5f6c804d7e@2ndQuadrant.com>
 <20170930222712.xgdgxnt4sjvig5mn@alap3.anarazel.de>
 <20170930224424.ud5ilchmclbl5y5n@alap3.anarazel.de>
 <75777957-d16f-f799-d0ec-bc3d5b7c72de@2ndQuadrant.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <75777957-d16f-f799-d0ec-bc3d5b7c72de@2ndQuadrant.com>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

Hi,

On 2017-09-30 22:28:39 -0400, Andrew Dunstan wrote:
> >> But even after fixing that, there unfortunately is:
> >>
> >> static void
> >> set_sig(char *signame)
> >> {
> >> …
> >> #if 0
> >> 	/* probably should NOT provide SIGKILL */
> >> 	else if (strcmp(signame, "KILL") == 0)
> >> 		sig = SIGKILL;
> >> #endif
> >>
> >> I'm unclear on what that provision is achieving? If you can kill with
> >> pg_ctl you can do other nasty stuff too (like just use kill instead of
> >> pg_ctl)?
> 
> 
> I put it in when we rewrote pg_ctl in C many years ago, possibly out of
> a superabundance of caution. I agree it's worth revisiting. I think the
> idea was that there's a difference between an ordinary footgun and an
> officially sanctioned footgun :-)

Heh.  I'm inclined to take it out. We could add a --use-the-force-luke
type parameter, but it doesn't seem worth it.


> Haven't tested on MSVC but with this patch it passes on jacana (mingw).

Yay!  Thanks for testing.

Greetings,

Andres Freund


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers