Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2nDQ-0001YK-TW for pgsql-committers@arkaria.postgresql.org; Thu, 12 Oct 2017 23:48:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1e2nDQ-0008DO-GG for pgsql-committers@arkaria.postgresql.org; Thu, 12 Oct 2017 23:48:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e2nDP-0008D1-VM for pgsql-committers@postgresql.org; Thu, 12 Oct 2017 23:48:36 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e2nDM-0001hB-Jo for pgsql-committers@postgresql.org; Thu, 12 Oct 2017 23:48:35 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CCA1920E92; Thu, 12 Oct 2017 19:48:30 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Thu, 12 Oct 2017 19:48:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=owE22cKryKNZ9CwLiMbmY6YxgGAnF qDQc0nEmuBBe70=; b=jEIPbLHyeGVsMXMMBgHhcJE8D20zwHpDfRca3oZaQ2E/s cpd2kuA3GV+ZuhYREQO4gw6A/BCCbmS2tso7wD8snvHWwnPz6sPSALF1qG8jK6ZV mpKybQEVPHU1ZXgYvIvqPnL3Grzaoe1x0SN3/1ysQZ+MblAIJaVzpxzWO+n8/jff TFSnNY4CID4KKLQBn4+ry+oDzugQPMyie3Qt1/7bk7DQ1KwkLxED1O+RgeawwJVC Nr2lOEvzSwv2F91vnnrGfl42GfRgkiuUMyCL9zsAmXiDP+LYQEVilXT6emekNtIr Yt4F2U3JBQ4X6tj1QLQ8dYgYXAeP+qbevTu0FE3NQ== X-ME-Sender: Received: from intern.anarazel.de (unknown [136.24.76.72]) by mail.messagingengine.com (Postfix) with ESMTPA id 7E98C7F91C; Thu, 12 Oct 2017 19:48:30 -0400 (EDT) Date: Thu, 12 Oct 2017 16:48:29 -0700 From: Andres Freund To: Tom Lane , Noah Misch Cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage. Message-ID: <20171012234829.efaorzn6daebxppc@alap3.anarazel.de> References: <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On 2017-10-12 16:08:44 -0700, Andres Freund wrote: > wrap-gcc -D_THREAD_SAFE=1 -D_LARGE_FILES=1 -maix64 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -I../../../src/include -c -o auth.o auth.c > auth.c: In function 'auth_peer': > auth.c:2002:2: warning: implicit declaration of function 'getpeereid' [-Wimplicit-function-declaration] > if (getpeereid(port->sock, &uid, &gid) != 0) > ^ > wrap-gcc -D_THREAD_SAFE=1 -D_LARGE_FILES=1 -maix64 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -DFRONTEND -DUNSAFE_STAT_OK -I. -I../../../src/include -I../../../src/port -I../../../src/port -DSO_MAJOR_VERSION=5 -c -o fe-connect.o fe-connect.c > fe-connect.c: In function 'PQconnectPoll': > fe-connect.c:2382:6: warning: implicit declaration of function 'getpeereid' [-Wimplicit-function-declaration] > if (getpeereid(conn->sock, &uid, &gid) != 0) > ^ > > Looks like we're missing > #include Hm, it got removed as part of http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9e3755ecb2d058f7d123dd35a2e1784006190962 but that's not an explanation, because c.h includes sys/types.h. Which according to IBM's docs https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.basetrf1/getpeereid.htm is the right thing to include. Given that xlc doesn't complain, I'll just assume this is some issue with the headers gcc uses on aix, but I'm far from confident. Greetings, Andres Freund -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers