Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2ppQ-00044F-Jg for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 02:36:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1e2ppQ-0006nh-6M for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 02:36:00 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e2ppA-0006Lf-DJ for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 02:35:44 +0000 Received: from mail-pf0-x229.google.com ([2607:f8b0:400e:c00::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1e2pp7-0003Lb-8o for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 02:35:43 +0000 Received: by mail-pf0-x229.google.com with SMTP id l188so7760163pfc.6 for ; Thu, 12 Oct 2017 19:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gI9eggpeA5EvSjRlxLPcO6jHiC881jkAbQLz0HQXVmE=; b=fgd9VfWM/FlwTuB0wavHJdJUKvE/9n/SCj+ofmF/S4zL+EjHcEhswlvZp5zueo7cmQ T64k09XoCgwRMeNL9ydc9RPWAabKiQBPcyRp41UeWDo1RmkJwkZcXn9X64atxKkI5BTY R/ZraUWLtDNJt7gxSPpxGhV59bLV3kvIzvHG0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gI9eggpeA5EvSjRlxLPcO6jHiC881jkAbQLz0HQXVmE=; b=BUTj+LCL+J68piO3KAnm4PqKwHYTq+dMHjfHK7QZwx6afReJNXSy+66WFT6O1HlrFm 76s1/ttx3S2s7Eh5KGp6YKB+6tmdhOJfxbALiwuk3ijfyLegf13lkPK56T7MPGrfk5zX fw+hvaIUc3Qn32zlcOGF0y/eis7oXORYsT+44my8Xgq6tQnVt0GffpgjLwEVAKGL/Bnw qNMLm2i3GYN0HFCt/BPboD5QZCK1Zgh6w66CtCWH0nDEWBUej7vsI7l3CbFvSzbF7EH1 3xFhVTnlgLWYXgIr7n+ZAuUiNDkYWEW9XeBTUyhYvhBiCRMfK7sikJsC5sp86clmWm9c 5ivg== X-Gm-Message-State: AMCzsaV3cz8Ni64CcG+hjgkRQ06wyG+Gse7+QzrER9oHWXQWo+t+sAqM BBQ/+exHNdzKZy9cnhdpJ8eOc7UAL8g= X-Google-Smtp-Source: AOwi7QD+6veQNWTGJeSBoJs07xVlRWTuz5ZLI6Axg8SWHBcx/XMHJ1pokCBfDBKbFXiz2feCZ/WcGA== X-Received: by 10.99.49.130 with SMTP id x124mr1762357pgx.367.1507862139723; Thu, 12 Oct 2017 19:35:39 -0700 (PDT) Received: from rfd.leadboat.com (c-73-158-248-138.hsd1.ca.comcast.net. [73.158.248.138]) by smtp.gmail.com with ESMTPSA id z8sm33321836pfl.135.2017.10.12.19.35.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 19:35:38 -0700 (PDT) Date: Thu, 12 Oct 2017 19:35:36 -0700 From: Noah Misch To: Andres Freund Cc: Tom Lane , pgsql-committers@postgresql.org Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage. Message-ID: <20171013023536.GA492146@rfd.leadboat.com> References: <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> User-Agent: Mutt/1.5.24 (2015-08-30) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote: > So we've two animals (hornet, sungazer) that are: > #define SIZEOF_SIZE_T 8 > #define WORDS_BIGENDIAN 1 > #define restrict __restrict > > one compiled with xlc that fails and one with gcc that succeeds. I'm > hesitant to reach for that, but I wonder if there's a compiler > bug. Alternatively there could be some undefined behaviour here that > only triggers on xlc 64bit, but I'm not quite seeing it. > > Noah, any chance you could force restrict to off on that animal? I can confirm it allows "make check" to pass. Specifically, I did this against commit 91d5f1a: --- src/include/pg_config.h~ 2017-10-12 18:11:33.000000000 -0700 +++ src/include/pg_config.h 2017-10-12 18:22:34.000000000 -0700 @@ -929 +929 @@ - #define pg_restrict __restrict + #define pg_restrict @@ -934 +934 @@ - #define restrict __restrict + #define restrict I have no reason to believe this is specific to hornet's installation, so I recommend against altering hornet's configuration. It's too likely that the next xlc user will need to do the same thing. I don't see the problem with xlc 13.1.3, though. > Otherwise I can push a platform fix that disables it. This sounds reasonable. nm -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers