Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2psd-0004EG-1m for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 02:39:19 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1e2psc-000722-En for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 02:39:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e2psc-00071s-2B for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 02:39:18 +0000 Received: from mail-pf0-x22c.google.com ([2607:f8b0:400e:c00::22c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1e2psU-0005Is-Fy for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 02:39:17 +0000 Received: by mail-pf0-x22c.google.com with SMTP id a8so7325548pfc.0 for ; Thu, 12 Oct 2017 19:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Fg6V2x2fAfFec2wWiWkN3vklkwnPovX/Vulv/6ooGnw=; b=Yrjxt9b4aaxzU1n7lqM21GBExxdhHs658N/KuET3plDQLt6+HF5JUov0rAoOCEvBUz GxALB93Awf2nI+Pk5rW/nJZUpzdO0aneumX3Ir36WQzbNdJpt9ZjQxoYtwVUcYhsphUA tWaDVWtxq06hCUDvR0jBebqtAGWtJF9pACfUE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Fg6V2x2fAfFec2wWiWkN3vklkwnPovX/Vulv/6ooGnw=; b=ak+XjmTAIsADJGtzkLTgFCcgbXsVNEboWuGTVhKihmNK/9aBAo8z7s//0p9YmqXcIC vIkx0fqnflpTWsXGyQIZcDhCMlzzlQn8SYm2MYXfqPIwJEPzLQpgTNjTBf1rkRs7CbVH wJvRyzPX0PNPBDw3OUz18GCpZSH1slY9UI4we+1ymMtVZKtfhzZs3tQTma5nvtHG6WP+ vA8vM56B8cVlf0tR7NXcZxHNEitfatBrpuWa/X7Dl0MgPobgU119YWHdnhkz/HRVk8HB T/c10FgpT3v5a81V6am+moDirpPjUMOekI2JAtW0M3O0TDxkiP2DV7D4A7AvwuSAhvE5 hB/g== X-Gm-Message-State: AMCzsaU5NmLeDt6uRELq7OZp4pD8rQSDJASsdUkVhhjEXN3bqL9WUS7L X6jV2QTn+nQoL7SNJR4u1jdcyw== X-Google-Smtp-Source: AOwi7QBPpsCog3LDN9LQR64h0SPE3JdCTZBwgJ/1V2B4Ibzf+5s30QCNQTjp3oFbRCIbkZLa+oppdg== X-Received: by 10.99.184.25 with SMTP id p25mr1736472pge.180.1507862348040; Thu, 12 Oct 2017 19:39:08 -0700 (PDT) Received: from rfd.leadboat.com (c-73-158-248-138.hsd1.ca.comcast.net. [73.158.248.138]) by smtp.gmail.com with ESMTPSA id k8sm27586784pgt.22.2017.10.12.19.39.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 19:39:06 -0700 (PDT) Date: Thu, 12 Oct 2017 19:39:04 -0700 From: Noah Misch To: Andres Freund Cc: Tom Lane , pgsql-committers@postgresql.org Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage. Message-ID: <20171013023904.GB492146@rfd.leadboat.com> References: <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171012234829.efaorzn6daebxppc@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012234829.efaorzn6daebxppc@alap3.anarazel.de> User-Agent: Mutt/1.5.24 (2015-08-30) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On Thu, Oct 12, 2017 at 04:48:29PM -0700, Andres Freund wrote: > On 2017-10-12 16:08:44 -0700, Andres Freund wrote: > > wrap-gcc -D_THREAD_SAFE=1 -D_LARGE_FILES=1 -maix64 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -DFRONTEND -DUNSAFE_STAT_OK -I. -I../../../src/include -I../../../src/port -I../../../src/port -DSO_MAJOR_VERSION=5 -c -o fe-connect.o fe-connect.c > > fe-connect.c: In function 'PQconnectPoll': > > fe-connect.c:2382:6: warning: implicit declaration of function 'getpeereid' [-Wimplicit-function-declaration] > > if (getpeereid(conn->sock, &uid, &gid) != 0) > > ^ > > > > Looks like we're missing > > #include > > Hm, it got removed as part of > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9e3755ecb2d058f7d123dd35a2e1784006190962 > but that's not an explanation, because > c.h includes sys/types.h. Which according to IBM's docs > https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.basetrf1/getpeereid.htm > is the right thing to include. Given that xlc doesn't complain, I'll > just assume this is some issue with the headers gcc uses on aix, but I'm > far from confident. The relevant xlc warning is disabled by default. "xlc -qinfo=pro" does complain. provides no such prototype. provides a getpeereid() prototype, but under C++ only. (For getpeername(), it provides both C and C++ prototypes.) Thus, the AIX documentation is wrong, and /usr/include is buggy. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers