Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2uSh-0003AG-2O for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 07:32:51 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1e2uSf-00071K-Om for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 07:32:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e2uSf-00071A-Cn for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 07:32:49 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e2uSc-0003R5-76 for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 07:32:48 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2A7A820D2D; Fri, 13 Oct 2017 03:32:44 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Fri, 13 Oct 2017 03:32:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=nyCFlx4XZn0lFje1YQtHsR+saXuJQ Cg1C1TYm+9ITtw=; b=Hlca3Ah9xWBib7XXgxVP3sVNc8pyHOABandQdxYoN7grc HM4spzOPN1dHC4u5QXq4VYdosDxkLd0JkH+I22BDnI2AnZTXSklLYbafq7/sB6qJ qCLrBznhmIGle6HmCSitDgEz5uHlwdPkwh79lXFM0jx8EWiGCpoEyV2Fsia08g5C 5IpOgB6Z6Hd4vVeGoDN2PsTtXtNpwrhgehXbENszM202PvzIT4rCDFRcuDpPn2lV s27fB0mMGuGnbAWNMYSnw00UEpiB0cWwqKjwViDFdF/3hQ4CggrL9G+SYEmognfB 2FXefHNIGvNf/NXJaTDSfDpR98wEGOUuXl9JcHGFA== X-ME-Sender: Received: from intern.anarazel.de (unknown [136.24.76.72]) by mail.messagingengine.com (Postfix) with ESMTPA id D9B852473E; Fri, 13 Oct 2017 03:32:43 -0400 (EDT) Date: Fri, 13 Oct 2017 00:32:43 -0700 From: Andres Freund To: Noah Misch Cc: Tom Lane , pgsql-committers@postgresql.org Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage. Message-ID: <20171013073243.gwie26wnivefqntf@alap3.anarazel.de> References: <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171013023536.GA492146@rfd.leadboat.com> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On 2017-10-12 19:35:36 -0700, Noah Misch wrote: > On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote: > > So we've two animals (hornet, sungazer) that are: > > #define SIZEOF_SIZE_T 8 > > #define WORDS_BIGENDIAN 1 > > #define restrict __restrict > > > > one compiled with xlc that fails and one with gcc that succeeds. I'm > > hesitant to reach for that, but I wonder if there's a compiler > > bug. Alternatively there could be some undefined behaviour here that > > only triggers on xlc 64bit, but I'm not quite seeing it. > > > > Noah, any chance you could force restrict to off on that animal? > > I can confirm it allows "make check" to pass. Specifically, I did this > against commit 91d5f1a: > > --- src/include/pg_config.h~ 2017-10-12 18:11:33.000000000 -0700 > +++ src/include/pg_config.h 2017-10-12 18:22:34.000000000 -0700 > @@ -929 +929 @@ > - #define pg_restrict __restrict > + #define pg_restrict > @@ -934 +934 @@ > - #define restrict __restrict > + #define restrict > > I have no reason to believe this is specific to hornet's installation, so I > recommend against altering hornet's configuration. It's too likely that the > next xlc user will need to do the same thing. Yea, I wasn't trying to propose that - I just thought it'd be easier to narrow down with access to the machine than 6h cycle buildfarm debugging. > > Otherwise I can push a platform fix that disables it. > > This sounds reasonable. I'm not getting a great vibe about the aix/xlc quality in this thread :( Greetings, Andres Freund -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers