Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e34H2-0005U5-9E for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 18:01:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1e34H1-0002Ut-KV for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 18:01:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e34Gl-00017e-HX for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 18:01:11 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e34Gi-0002T9-UP for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 18:01:10 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2304720E0C; Fri, 13 Oct 2017 14:01:08 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 13 Oct 2017 14:01:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=mpRxcEnUgt4a+PymSZszRbuHpCK+g F7VN8ek8yW5aWw=; b=kRGsRY9iOJL7ljgpZrc0/z8V5Ena4M5BujJkaBeZ1U8mj F5yDXRAvoFauv1l2JzFsN+MWCm2rnB4YBpI9gMy9olGgNLxcNcFq8fGRLWIxB+J3 TghQBq+RaDbxp5/DeLuXGoDRj9sztoZHY5W/IAaJAf5HCHwCYLZNAvCZdi8lLLDD C17pZbJIMYCrZkd//lf8/U7mbYYf5tFazhfZfafqwJ2WRdM3cZPe8ts8UMMXUnAc aArwpfCAboohuZP+bnb9IeqN0LJR49k0JqkJ3HjhgxQPzG1JM1YV10MdBItJM11G 50XwgObumdeUkpAleoZOWWLAFvU8vWezV2ed/3IEg== X-ME-Sender: Received: from intern.anarazel.de (unknown [136.24.76.72]) by mail.messagingengine.com (Postfix) with ESMTPA id D21447F96B; Fri, 13 Oct 2017 14:01:07 -0400 (EDT) Date: Fri, 13 Oct 2017 11:01:06 -0700 From: Andres Freund To: Tom Lane Cc: Noah Misch , pgsql-committers@postgresql.org Subject: Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage. Message-ID: <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de> References: <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> <12267.1507862660@sss.pgh.pa.us> <20171013070247.GA505228@rfd.leadboat.com> <21773.1507908395@sss.pgh.pa.us> <530.1507916887@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <530.1507916887@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On 2017-10-13 13:48:07 -0400, Tom Lane wrote: > I wrote: > > Anyway, I will go make the sizeof() usages consistent, just to satisfy > > my own uncontrollable neatnik-ism. Assuming that hornet stays red, > > which is probable, we should disable "restrict" for that compiler. > > As expected, that didn't fix it. Andres, are you going to put in > a disable? Do we know exactly what we want to test for that? A easiest way to do this would be to put something like CPPFLAGS="$CPPFLAGS -Dpg_restrict" into the existing if test "$GCC" != yes ; then block in a/src/template/linux. But that'd probably result in "macro redefined" warnings or somesuch. So it'd probably better to introduce a FORCE_DISABLE_RESTRICT=yes, set at the same place, that's then tested before running the relevant configure check? Greetings, Andres Freund -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers