Date: Thu, 16 Nov 2017 19:11:49 -0800
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Remove BufFile's isTemp flag.
Message-ID: <20171117031149.hslkxis732hkjuog@alap3.anarazel.de>
References: <E1eFVyl-0008J1-RO@gemulon.postgresql.org>
 <23339.1510887494@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <23339.1510887494@sss.pgh.pa.us>
Precedence: bulk

On 2017-11-16 21:58:14 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Remove BufFile's isTemp flag.
> > The isTemp flag controls whether buffile.c chops BufFile data up into
> > 1GB segments on disk.  Since it was badly named and always true, get
> > rid of it.
> 
> [ squint... ]  That used to have an actual purpose connected to
> transaction-abort cleanup, IIRC.  It disturbs me that this seems
> to have been

I've not found any such use, searching through buffile.c's history. I
don't quite see how that flag could've been related to abort cleanup
stuff?  There's been another unused caller of makeBufFile, namely
BufFileCreate, that has been #ifdef'ed out for ages (perhaps we
should've removed that with this commit or a long time ago).  Other than
that there seems to not have been any other caller setting that flag
differently since you created the file in db3c4c3a2d980dcd.

Greetings,

Andres Freund