Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRxAp-0003bf-IP for pgsql-committers@arkaria.postgresql.org; Thu, 21 Dec 2017 09:29:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRxAo-00037P-V0 for pgsql-committers@arkaria.postgresql.org; Thu, 21 Dec 2017 09:29:54 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eRxAo-00037F-NS for pgsql-committers@lists.postgresql.org; Thu, 21 Dec 2017 09:29:54 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eRxAh-0001R9-LJ for pgsql-committers@postgresql.org; Thu, 21 Dec 2017 09:29:53 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9A5C720D9F for ; Thu, 21 Dec 2017 04:29:45 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Thu, 21 Dec 2017 04:29:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=vSXlLYLNd+gP5AieAaQ7ja+vZeTm1 9rngEP/TPtsO5A=; b=hHU6IbHVWxRa4tfHfvtE5eXfhUB7vajh2puSXZIobK+aF cNZWMNmyAp4MSEYxM5mll4T9QPZy8m1O/CJu1aK8zR50XPuVRQbXIsOsFDwMNYtC 7Nr/O60vgZRrbUEwUTn8r8XZ5d8gRBnR2imOc3vPIjnVxD0PKKKkfweTX9frW4OP 0PjZp0zeKlnyiu2P/5sO+Dn+C6suyJpWcgVedeCdDHsFuTYwqhkpVhv0g0gQOGsk faIGdGkx2nYlpPp8KQx+755h1yVdDt5RU14eyeZ6FxR0DbdGULdQR1V++w0pzgvX QoV6w99/Nm+05qFXO4m0q5Rpak7WLtC+Wp8x+DsUw== X-ME-Sender: Received: from intern.anarazel.de (p5de63f33.dip0.t-ipconnect.de [93.230.63.51]) by mail.messagingengine.com (Postfix) with ESMTPA id 1587D2442C for ; Thu, 21 Dec 2017 04:29:45 -0500 (EST) Date: Thu, 21 Dec 2017 01:29:40 -0800 From: Andres Freund To: pgsql-committers@postgresql.org Subject: Re: pgsql: Add parallel-aware hash joins. Message-ID: <20171221092940.gbxcszbzsr5khsfr@alap3.anarazel.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2017-12-21 08:49:46 +0000, Andres Freund wrote: > Add parallel-aware hash joins. There's to relatively mundane failures: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tern&dt=2017-12-21%2008%3A48%3A12 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=termite&dt=2017-12-21%2008%3A50%3A08 but also one that's a lot more interesting: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=capybara&dt=2017-12-21%2008%3A50%3A08 which shows an assert failure: #2 0x00000000008687d1 in ExceptionalCondition (conditionName=conditionName@entry=0xa76a98 "!(!accessor->sts->participants[i].writing)", errorType=errorType@entry=0x8b2c49 "FailedAssertion", fileName=fileName@entry=0xa76991 "sharedtuplestore.c", lineNumber=lineNumber@entry=273) at assert.c:54 #3 0x000000000089883e in sts_begin_parallel_scan (accessor=0xfaf780) at sharedtuplestore.c:273 #4 0x0000000000634de4 in ExecParallelHashRepartitionRest (hashtable=0xfaec18) at nodeHash.c:1369 #5 ExecParallelHashIncreaseNumBatches (hashtable=0xfaec18) at nodeHash.c:1198 #6 0x000000000063546b in ExecParallelHashTupleAlloc (hashtable=hashtable@entry=0xfaec18, size=40, shared=shared@entry=0x7ffee26a8868) at nodeHash.c:2778 #7 0x00000000006357c8 in ExecParallelHashTableInsert (hashtable=hashtable@entry=0xfaec18, slot=slot@entry=0xfa76f8, hashvalue=) at nodeHash.c:1696 #8 0x0000000000635b5f in MultiExecParallelHash (node=0xf7ebc8) at nodeHash.c:288 #9 MultiExecHash (node=node@entry=0xf7ebc8) at nodeHash.c:112 which seems to suggest that something in the state machine logic is borked. ExecParallelHashIncreaseNumBatches() should've ensured that everyone has called sts_end_write()... Greetings, Andres Freund