Date: Sun, 1 Apr 2018 16:22:08 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Teodor Sigaev <teodor@sigaev.ru>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set random seed for pgbench.
Message-ID: <20180401072208.GB2211@paquier.xyz>
References: <E1f0U1H-00005J-98@gemulon.postgresql.org>
 <32390.1522464534@sss.pgh.pa.us>
 <alpine.DEB.2.20.1803310828100.23311@lancre>
 <10686.1522514072@sss.pgh.pa.us>
 <alpine.DEB.2.20.1803311936450.23311@lancre>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="U+BazGySraz5kW0T"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1803311936450.23311@lancre>
Precedence: bulk


--U+BazGySraz5kW0T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Mar 31, 2018 at 07:43:38PM +0200, Fabien COELHO wrote:
> Indeed, I clearly misunderstood its usage pattern. I looked at its source
> ("src/port/pg_strong_random.c") where the function is always defined and is
> documented as returning false if it does not find a strong random source, so
> I though that checking for this was enough. But indeed its
> compilation fails if no source is provided.

I have not check in details this thread so I may be saying something
stupid...  But if you are looking for a frontend implementation for
strong randoms, please extract pg_frontend_random in fe-auth-scram.c and
move it to its own file for example in src/common as a frontend-only
file.  When working on SCRAM, I recall mentioning that but Heikki has
kept the code in its current shape for simplicity.

As far as I can see, there is no reason to issue an error in
set_random_seed() either in pgbench code.
--
Michael

--U+BazGySraz5kW0T
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlrAiKAACgkQnvQgOdby
QH3PIw/9E2R0ngw0zYEURbdd2KzZIsuLzU9hx95hLxLZoFdfCwvTaFvoDaTovjrZ
XJkkXnS1aAyAv8RDdUc+khY6vg4JmVGCNur1QCPSYdzbCP6geG42iT5Ezy4rSYyS
dr52V46swmdy0XsOj+8y0DSVTWx27Ti3L5Ou9f9tOUpTzu2z/V2c7RKe2bd+7GNz
qafM5VQIJ7c3hDOK6oQxfzW5l0zufBTCKlgTw7TT8PVFnRFtXuc5QgGGJtzBgUSB
J2kGtQHLUT5xcDQ9pZCD3darTq93mWT6y0DQ4ZStcXDSy8KIYh26x6c4hFadocT+
6IuABVVT+PmlFPFLr/T0hW1DerhaH2bDw7emheeZG3gOQevlkZkhJgIUR/UWdQHK
Crxbc58+t9irZHRYhjGb2NfpE5Xz2KaSBTVgKpe5JMOgo1ScM6Qrj4c/vLXJbeIE
VKqYnkWiUT1C65OpYPaOjJCJcmyAvm5laXp/+5a8IchdcAb3JySaDycPwclPpH+G
KxJv2KE41W7fVVj9F5xHijmMvPFthAOPCEnbeF10CpI/N2mklRa8C/jYjJXfPKWf
SFd+E9Ty+zYwheJg8b5I+iOXtWFaprShK8rN/kfryyWcm14qoWQ6t+jj1b3WVl/6
vsDjmo7Hu+ok7U/WRKsfcfQSUb5MQ9az67py96VvAh1Rjcuhuu4=
=QhPx
-----END PGP SIGNATURE-----

--U+BazGySraz5kW0T--