Date: Mon, 9 Apr 2018 10:00:31 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h
 headers.
Message-ID: <20180409010031.GA11599@paquier.xyz>
References: <E1f5FAB-0006LU-MB@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu"
Content-Disposition: inline
In-Reply-To: <E1f5FAB-0006LU-MB@gemulon.postgresql.org>
Precedence: bulk


--WIyZ46R2i8wDzkSu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 08, 2018 at 06:35:39PM +0000, Tom Lane wrote:
> Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
>=20
> Traditionally, include/catalog/pg_foo.h contains extern declarations
> for functions in backend/catalog/pg_foo.c, in addition to its function
> as the authoritative definition of the pg_foo catalog's rowtype.
> In some cases, we'd been forced to split out those extern declarations
> into separate pg_foo_fn.h headers so that the catalog definitions
> could be #include'd by frontend code.  That problem is gone as of
> commit 9c0a0de4c, so let's undo the splits to make things less
> confusing.

This patch or one of its relatives has visibly broken parallel builds
for me. "make -j 4 install" directly called after a configure complains:
In file included from ../../src/include/catalog/catalog.h:22:0,
                 from relpath.c:21:
=2E./../src/include/catalog/pg_class.h:22:10: fatal error: catalog/pg_class=
_d.h: No such file or directory
 #include "catalog/pg_class_d.h"
          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

I did not take the time to look into the problem, that's just a head's
up.  I am on HEAD at b3b7f789 so it is not like I lack any fixes.
Please note that "make -j 4" directly called works.
--
Michael

--WIyZ46R2i8wDzkSu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlrKuy8ACgkQnvQgOdby
QH1etQ/+LUFlt3mcZ2LuwxUXT/cseimBifFy7Bf8NLtvbrkt9k9VEQwydl47/jX7
8RDAtdpdQ5sO2LJsr7JkLVtGF8cxNvnHB5V7/B025pjSVrps1rXuevKoVyvl17D3
iNoW2DJ7EIltTtCPb60ALxuVnkqEiKGPMRrrzhYx8d5J4jzK0IyZkzpV28FwWS3e
jEU7pDSGfVmV9oewWW2AZlOf08o8zH9H/RcwfH0nFyTk6FvadP1ofHvyviLMwlJR
5pQuY3WWoeWgy8zPD3FxFYrQJMaun5/bO9ln4Ka1wwz7P4vMN4qPol8aZ7tayZNY
eULoIkzp+Q7/80h9sPhZY1Oe1qToRCi+cuxt2/JtUnLuckVMydptpQTugEkyMb+h
pUZ2gaG9s1cam4HchLKUvB0fsADsNXmpmnIp7g17S5FbS/isXTcoUVRngSM1gfuP
cgBMKmD/kFSfh6Um0z3JaJjhK6mCwkwmxIiuDBaHgfb61e+tKXkOBTlRJ13IW0Cj
+1lB2dGQRcIOQLdUY0nkuNj4c0AHUwfxnw7JKZi2jQTudHmQ3i20WwcJs1N2FQTx
pxFyOnCzBg4xSna0NgTpbn1ccOffP3MHNc4+GD4cYm9xN6lP725F+r0VjgHEe1hN
yss7FQYPGPez7icPGmr4DZCiTKnlXFKU2VhbwS6GrEsU/+rimA0=
=BwUT
-----END PGP SIGNATURE-----

--WIyZ46R2i8wDzkSu--