Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f63M2-0002uS-FX for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Apr 2018 00:11:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f63M0-0007y1-PJ for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Apr 2018 00:11:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f63M0-0007xk-I1 for pgsql-hackers@lists.postgresql.org; Wed, 11 Apr 2018 00:11:12 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f63Lt-0005uV-Hd for pgsql-hackers@postgresql.org; Wed, 11 Apr 2018 00:11:11 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 48A13211B7; Tue, 10 Apr 2018 20:11:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 10 Apr 2018 20:11:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=vPzz/SNnB2fS9rw1jnR3hdJLjWOVwTUY376yq+zgh58=; b=p0C0pSro Grgy3tqIucXmi8y4+v13eTGvntej5lm7/sEH2GnJu5RL0ffsyguLMViBPPTVaRVD bErLxDV+/ZT5i7DEFk7H2J85MQOXA4q+uFPSB5KDHQ/fZ9Qpa2A1dqw79lvHHrVz AvEODLNCyDuOaZ76R9q88CfZVI1xEbXpg+nk05WB6FQE2JXcajhz3p3FTAT0fBem xINz5DHkuw0q+EoomeAimFWaEKKznZn5b7LCw6rtLX1799zdyWTq3AOwe2hX4EVd ACwvmgpvY/ZcTv0QtHr6F7oOWWuQ2Qgb2rY8WcSztNw2Pylbv5m3JC86PKjLM0Vw 6Pq3aSPJ3/Egng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=vPzz/SNnB2fS9rw1jnR3hdJLjWOVw TUY376yq+zgh58=; b=ZmgX758kiRo7q1mBYlRM668Zterc7txDnT7345DG7jl/8 bKORDEj2mQVUiubP0heYWN5YQSXg8EDvR3UGz5B4LV3NdVzGFuwla3AfhoLl3hQX JWJp+fMbno55K5H44e84Lkgo+zDLs6M7rv0G6m30qt1uLiR6v52lJCluj3YLUDWY aevN3sISN1eyDDqYuAopHAAW6PcVRnBJu471JdvZV7hhQKlvhVCRLMg15vP5LKfl tftjMAhYT6ym8qmjTLsS1c2WJ34xYGaV78ZEZE7m16LluUupQttEI+bIWkk+0NNI VTLiMtVFvL/CcXdXAHuOy/pmP38flNezE0RAO4ZGA== X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 12930E446D; Tue, 10 Apr 2018 20:11:00 -0400 (EDT) Date: Wed, 11 Apr 2018 09:10:58 +0900 From: Michael Paquier To: Tomas Vondra Cc: Magnus Hagander , Michael Banck , Alvaro Herrera , Tom Lane , Andres Freund , David Steele , PostgreSQL-development Subject: Re: pgsql: Validate page level checksums in base backups Message-ID: <20180411001058.GJ26769@paquier.xyz> References: <20180404121930.GE20852@nighthawk.caipicrew.dd-dns.de> <20180404134732.tsxx2osvooolxy24@alvherre.pgsql> <20180404182247.GG20852@nighthawk.caipicrew.dd-dns.de> <20180405124113.GH20852@nighthawk.caipicrew.dd-dns.de> <500ab687-d588-020a-0e23-bfec853aac9c@2ndquadrant.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="F4+N/OgRSdC8YnqX" Content-Disposition: inline In-Reply-To: <500ab687-d588-020a-0e23-bfec853aac9c@2ndquadrant.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --F4+N/OgRSdC8YnqX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 10, 2018 at 11:35:21PM +0200, Tomas Vondra wrote: > BTW pg_verify_checksums needs the same fix. Yes you are right here. Just for the record: what needs to be done is to check for PageIsNew() in scan_file() before fetching pg_checksum_page() and after reading an individual block, which applies even to what HEAD has for pg_verify_checksums.c. I am adding an open item for this one. -- Michael --F4+N/OgRSdC8YnqX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlrNUpIACgkQnvQgOdby QH2nWQ//eW67CrxxXGmDgdy1NjDV9KegkqRI9AxcF1oKNYEqpB8p+jTTruWS5M2d Lrwq7G/WueBfIqyYlBIQ8UG0vxL/bEf9L89+Exmq8vwQVGkI/b/Xuf0HDBhnVTRe NdzSfhh4uitTs2m5j7GdiZYTtEYOMsp3yGmeywxHjn1tEeeHdPmWXG7uoYdxwiKp ACES10n1j9/oI7S9fd3Vy//602lZ7x1nPzmvsMbPLCoCRI2XsEb9zQhiPfljnBXG tRneXomZdrC9YbAiKVsF3Wk2iDnOCOnQt1fFFIje1ni+RrYHAByq7P3x5qS2IgnL RcErmD4N9ej87FJ/0BHr0fpPlXjkHeP7heDYiuzKnpAm68yn8HR9fWYjoBBlcx4j M8gBTqkuDAOxHrs1vtVjaD26jMVOHiS+Mg5xjhJaEanrcF9q+GLAUJBWNx2emoru pOJrGkWFMZOCjJkhuLgU1+QxrU3m4bdJFfBGYBUQxsIgANCHTJxYm5On0vF5awym DQjsPQUULt41OMk5gYGhLBQKr4THKemBe0PbD0vG3DeWlIQBuhqRsrm4OetZJbOi ef3yDxyKLoas+lkL0sPWJWhR831l3O6HBVshcsrLzRd35Avl66g7R5FUg8bd6N+P zKRVUYvN2dd1qOhwqSDzBZynUHI6pswJP9MgDYJiinBgYmtmoPU= =2dUZ -----END PGP SIGNATURE----- --F4+N/OgRSdC8YnqX--