Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fdWVU-00089o-Nm for pgsql-committers@arkaria.postgresql.org; Thu, 12 Jul 2018 07:59:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fdWVS-0006n6-CR for pgsql-committers@arkaria.postgresql.org; Thu, 12 Jul 2018 07:59:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fdWVS-0006mt-7t for pgsql-committers@lists.postgresql.org; Thu, 12 Jul 2018 07:59:18 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fdWVP-0008N1-ST for pgsql-committers@lists.postgresql.org; Thu, 12 Jul 2018 07:59:17 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9050E21908; Thu, 12 Jul 2018 03:59:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 12 Jul 2018 03:59:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=/p4/v2QCyF24Z4L/arGnsfi9mQKzJNcgfl032pdvKCE=; b=v3CFFNsf 2KnyPjrhaRicIx0vCfYMpDOVTKmhawEB61+yqBVf842xJAZDM88WxVW7N46x7ON1 PQ6UMOJhP93yO+HIVg2Izet8IWPhWCOw6/P8tPYaYVFNa/440nzSxgLQ4bKDhlqs srjLGCss9ozBp67pdQWbqrWwoJAniZPuRAoR9Excc4Ih4ofhjyLZDy+o+zinSaLb 7esvVMr/b0uT++D0rEke4FE2ShckZg49Tkk7cXcxAKh0cZkK3HNEu8ilvyyaakU+ fj77utfQrNbH/Sdb14dgNHtAs+pL9Yr2Tsf8TWmmMoGEGO2VXzgQTxvId7ajHUR5 zGXp0u0yj01aKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=/p4/v2QCyF24Z4L/arGnsfi9mQKzJ Ncgfl032pdvKCE=; b=NHQb69h1UyGnw97qfdpBGnsUTVUvgXBPLvNQbU7LVcB3c 4j18/T9B9wFd1g+NgFe77MjwTZjREzj3STzzWZXjT6gnThMffFFohV0EZhHeZqD4 qH8uFph3XRtZasx/L6GiwiK/rgoXVle1bGFqOBdVpJcaDjnlRS/WVAWxs8ifvEOl FPCrMWxLBzYDRHWuQ6I2695BKo2GLDqNpzqXFdAxuOa+R9nKyDZ1TukKI5jdREbC 5sO04DVpwTpZj+aKRfZ4AHVkMNVHxlCeqM1Sq5qivehmO1P2G3FMce60TGX1bcgF cJOMiX3CnzLzTaySgeIf50RGVMUjAX45feD0Fpj/Q== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id A19C010277; Thu, 12 Jul 2018 03:59:12 -0400 (EDT) Date: Thu, 12 Jul 2018 16:59:09 +0900 From: Michael Paquier To: Amit Kapila Cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Allow using the updated tuple while moving it to a different par Message-ID: <20180712075909.GG7352@paquier.xyz> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="G3juXO9GfR42w+sw" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --G3juXO9GfR42w+sw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 12, 2018 at 07:33:54AM +0000, Amit Kapila wrote: > Allow using the updated tuple while moving it to a different partition. >=20 > An update that causes the tuple to be moved to a different partition was > missing out on re-constructing the to-be-updated tuple, based on the late= st > tuple in the update chain. Instead, it's simply deleting the latest tuple > and inserting a new tuple in the new partition based on the old tuple. > Commit 2f17844104 didn't consider this case, so some of the updates were > getting lost. >=20 > In passing, change the argument order for output parameter in ExecDelete > and add some commentary about it. Looks unrelated, but flaviventris (a snake?) has just complained: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dflaviventris&dt= =3D2018-07-12%2007%3A36%3A01 -- Michael --G3juXO9GfR42w+sw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAltHCk0ACgkQnvQgOdby QH2YkQ/+O5zUXwuLhmXcyej/hNQha+B8ejrMkHKGvEHcX0ISKCPUDZQdQ4TuEZkv 49nq3c+Jghx7QrGAyV2179ISEEuQyUzs+19iLhYZm3O0sPtnw8i49EZwvZIKWeFz 4TiwQt70YMrOcmRG5HmzXdXmpcQqRKX9fucQ1ddPH7kmEgxMHf3+hpaOMzlsYaOh nNMNTQlWAslDHMKfOt73JKn+KxSUSVPYSYPOzqVvNIDfqv4IzMQmSjDkun2bll3v qpmRV7YUNh80xkuffXWOuvpJV/ipwmGpA9EEUxkF4P5hOKdlYj9Vrzjmrg5omJAT POiuqCBX8ZR1N5PMwVU4b3EM0pFxiS76D3pAstO/XHwzhknCbIm99xc2PsdcGmkk kGwSywK/b6uVTGX7zkToSd8sukAxNYHtS+ygY7vte5e4BhWE5TRWLaGqUUFgN0+U nbeyVhRvPrdY6yO2ZoTqnvkKDlHlvONDslA19ow4XYcvSEU7TxnPkhkWksEQpeq/ BK8tOOzPeusgxujKobwnOAXFUx5aRnmqilKYEDOJS/TG3etW52ZSNXMbuL5Pkht/ 1TF3L+/ViGAaINQ7dRXdfZIqBbL9dj0mrcGaTacmro3dIfYDqawqQ6t0iputuNlA 5K7NzlfHEASvNK1cDms7tc8ZWu6riY2a7GvYJCDt1Emsdq4OYwo= =qa7H -----END PGP SIGNATURE----- --G3juXO9GfR42w+sw--