Date: Tue, 28 Aug 2018 14:37:01 -0700
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
Message-ID: <20180828213701.GL29157@paquier.xyz>
References: <E1fudM8-0000af-Lm@gemulon.postgresql.org>
 <12438.1535488750@sss.pgh.pa.us>
 <17758.1535490505@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+ARLBH93C7pgvpZY"
Content-Disposition: inline
In-Reply-To: <17758.1535490505@sss.pgh.pa.us>
Precedence: bulk


--+ARLBH93C7pgvpZY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 28, 2018 at 05:08:25PM -0400, Tom Lane wrote:
> I wrote:
>> Digging, this is because the "make check" processing isn't actually
>> installing oid2name (resp. vacuumlo) into the temp installation tree :-(.
>>=20
>> I don't think this is the fault of your tests, exactly --- there's
>> something wrong in the existing make rules.  I'm not sure what though.
>> EXTRA_INSTALL should be getting set, according to pgxs.mk:
>> temp-install: EXTRA_INSTALL+=3D$(subdir)
>> but it evidently isn't.
>=20
> Oh!  The reason why not is that that line is inside "ifdef REGRESS",
> and these subdirectories have no REGRESS tests.  So we should move
> that out to where it will apply regardless of that.  Will fix.

Yes, I was going to send a patch along the same lines as what you have
just committed.  Thanks!  It looks that the binary was installed in my
own PATH, so I did not notice it.

This should definitely get back-patched in my opinion, I have similar
problems with pg_rewind tests of 9.3 and 9.4 that I still maintain out
of the core tree, where the main binary needs to be installed first.  In
this case I just used some Makefile trick.
--
Michael

--+ARLBH93C7pgvpZY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluFwHwACgkQnvQgOdby
QH3pxg/+NZawVtkEjgwSvwvvZloFNUAnORYnRj6QpC9CYS2e5ylc/pb0dOs4RWh2
/WHZ7wfrhIOY8CgIe/RmQeOLBvOlm55ZHXpDYpLGByREWDljS7uv7ddQJ+FIbYg3
BSjd43z7PKbmgo5grrYZAf33ncTR1wn2Nc/nyle6BPjzLazzsij3e3pKZgM1x8Ea
fe+KtDWmGDd9FjYwW9cm6VvBLaz1Je3ReQVrdHBWPZn2v29mdZKiHPAzy2f/LZvc
1JPQ9oGHki/Z+YuYmJVVLW8uE1dhY4EZ38bwjP9MoX226dUQ/caU0YTE66FeO/z6
rPx5fVAJXW87xFqXBdX1T2wVsmAnG0YKBg6fB+YluGb0HQeWn0u+H8KqG6xqdPMQ
eE8b1NWOh+6swaUeRf56yTvqUnI/aI+qUhMn+r9lrDtw3H8i7O1MzSHXIW0ID5EK
JSULFI6EBLkJScv2JmCbsvlLD9IXY7EteK8femIcRclpPJHpqoo1llpFswddRLOe
Rn/GxmQT5OBgxwG1zdxVpbWOwOO423b+9ciscg1OETsOUDZ7mQdR9H5vYLpsmW2V
wJW9ZSn/9YbK03KN7ktaRoxgVi0X9qHnVohZuRG9qQd+JBY7kTS2KbosJAq59wDh
yjCYA/CrrDNkZxL8YkKdy/o5o9ZUFgn5wW5rZ3d10Cdcfdd6zvs=
=zSyx
-----END PGP SIGNATURE-----

--+ARLBH93C7pgvpZY--