Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvBp0-0005Ji-0w for pgsql-committers@arkaria.postgresql.org; Thu, 30 Aug 2018 01:32:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fvBox-0003RH-1t for pgsql-committers@arkaria.postgresql.org; Thu, 30 Aug 2018 01:32:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvBov-0003RA-IH for pgsql-committers@lists.postgresql.org; Thu, 30 Aug 2018 01:32:26 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvBor-00051K-SR for pgsql-committers@lists.postgresql.org; Thu, 30 Aug 2018 01:32:24 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DE726406; Wed, 29 Aug 2018 21:32:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 29 Aug 2018 21:32:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=mFPAlj2wSn4AQAsenaZUv8igecXQ7g09xiCXaWjFWkQ=; b=kAz+YnEV zhBnw4rcZhJBzNIW2wBb97Qip5eRvLO5hP9JFWviz442e480dx/6qeGBzXFT4kKi 4ruWzfx4l+E7Ta7NKST2golqJn9qDuSxbiLPdZnT+OtYMWRhD+wbe6be6s/dOOgH AIZOVh6nXkARzopxnsV6qrs/AtYJeORQ/pPuKqhmg823aZob+VhpOu0pBxB3G9M0 VxlyJNWW8GPtvDm/pyLL1UnT94uGjFWU3HLzD77d0RWZFcaMP5Cbtv+iDvWQneH+ dhS7b4v4CnfR2uBKw1uX+GqfGHh0VYyd8YNetgvMcyDW+ouqb1DgQUVuco1rFgQr 0UT2GrMtu8FlSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=mFPAlj2wSn4AQAsenaZUv8igecXQ7 g09xiCXaWjFWkQ=; b=lkhfSHqFLuezDWErantAmIOsXZc5HpEKAHkoKbgbLfgHC sRWoEuH6ynA10yE/PgTIDtefJ5QZ3JElYdGaq8VuvYOu4DeQpsjSCD2QSvk1FUOz flv21vOB1StrWeN6i5NEYxALRNc5O7nTEe96+ZAYXpL/VJ6WSRfp8aZxf0UKIM3J KeHD3l9/CZJmWBg1uLKxwrRVHX46uc9xkw5IzyBP4dmMeOf54ZIvV+boVuCHiK5M wW1SdF4QWEOCd+OJpJOc+n2HkKCZre4TAJy7w4OWjj0dVvQ6S6PEq2baYu7W+mWB j54QfRgbwAwmvQMXTv9g2SvHb9HedpBgdhp5Kp2Rg== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (unknown [208.91.3.26]) by mail.messagingengine.com (Postfix) with ESMTPA id D09C410288; Wed, 29 Aug 2018 21:32:17 -0400 (EDT) Date: Wed, 29 Aug 2018 18:32:15 -0700 From: Michael Paquier To: Tom Lane Cc: Peter Eisentraut , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Rework option set of vacuumlo Message-ID: <20180830013215.GG5903@paquier.xyz> References: <12438.1535488750@sss.pgh.pa.us> <17758.1535490505@sss.pgh.pa.us> <20180828213701.GL29157@paquier.xyz> <7228.1535492867@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c7hkjup166d4FzgN" Content-Disposition: inline In-Reply-To: <7228.1535492867@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --c7hkjup166d4FzgN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 28, 2018 at 05:47:47PM -0400, Tom Lane wrote: > I didn't want to backpatch further than v11 without a test case that would > work in those branches, and I lacked one. If you've got out-of-core code > you could verify it with, please do that and back-patch further. Was there any need to patch v11 with that actually? As there is nothing which needs except HEAD that does not seem strictly necessary. I have reviewed the modules I have, and actually it seems that I would not need much of that for a back-patch. One reason being that most of my TAP tests need pg_regress so as nodes can be initialized so this needs an external installation anyway. Maybe others have more thoughts to offer and would prefer a back-patch. -- Michael --c7hkjup166d4FzgN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluHSR8ACgkQnvQgOdby QH2KGRAAi/64nCIcQbvb35mbqfWeFo+lzXvWCleW6mlus6waL0J40JndUOz4AGhh WwFqY51REo7CeRUThB2ELvFUjhHkLqiA5O56PIkUo4v9Aje32jVYiL0VPMRtY5xP liDlsi8iXabVc4WVAdrtcgcygORQsWvd+ysfOo+ghQeu5HL3IRGOsAYX1NL/BL4b lC51CpnZj7oWajBHGJavRF0I4LlYGt+9neqME+6AqRZLh2VV3+mdSpDKFAmUSyaz RF2If/W9bwdBAbiHVUb+ozf3Zt6iqSQDie5k6YmrnRqyBVdEJnZ60KMN/qfUN1w/ 7uz7GEVqmv8CTqzg8YK94GEbOvGlZCNH+XudB+AJNcqJRvL6JwnIMbflGjzXJHYU s3evaAyU1dVtH5kuWHBjV3JWeUkUlR4AODuwgFQlqXuSq6lFs6H7YFnraphzAfjy H5cCnAqTX5cCGYNnRX4gyRhQzDMMHh4rxv+CyIHANoXgU3SRYx6Pxpe2/AcTg808 Tkkex5aTgMGSHnM77q4wZrunEMcico5xx2NF6TJioh3Mi7YUsZZlVqsjk/RUYCFM 7BvtNz9MpEE9fq50qDlvNcw24v/h9++AtrqpJ1IEjiGxyPXO9Yo96J5LuxqQw4cO 2No4f2K4Gk1GqA3x8DnIPIxV/tugldYbZbLCRE+2yTFkUVu+i3E= =dWyz -----END PGP SIGNATURE----- --c7hkjup166d4FzgN--