Date: Sat, 15 Sep 2018 07:49:39 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code
 for Wi
Message-ID: <20180914224939.GA1178@paquier.xyz>
References: <E1g0cYN-0003oE-IE@gemulon.postgresql.org>
 <23543.1536938575@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6"
Content-Disposition: inline
In-Reply-To: <23543.1536938575@sss.pgh.pa.us>
Precedence: bulk


--IJpNTDwzlM2Ie8A6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 14, 2018 at 11:22:55AM -0400, Tom Lane wrote:
> I'm surprised you didn't back-patch this --- isn't it a bug fix?
>=20
> A compromise might be to push it to v11 but not further.

Yes, that's clearly a bug fix from pg_ctl point of view with TAP tests.
However, I have rather cold feet about back-patching for two reasons as
this introduces a behavior change:
- The concurrency part disappears.
- Caller of open() needs to enforce text mode to strip correctly CRLF
characters.

I would be fine to get that into v11 though, as that is not released
yet.  You will have to wait for a couple of days though, there is a long
week-end here away from laptops and electronic devices ;)
--
Michael

--IJpNTDwzlM2Ie8A6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlucOwMACgkQnvQgOdby
QH29chAAqG4qenq8WDIZGm/BeE55JnZBotEq22gcYrrrGaCYO/rVYaTtPAHXI91y
j2q1MIn/F+YNP3OwsZR5WP0A9oVyttjKm6ret8VKaWSjMkCj3rviOaIQOM6Q0ubj
z2hYTPF9G27FM9+ZvCPaME1ne3eoDubALAlFiEYNRYhMNKpmF6x21s4BXN9yVkvk
K4bILvBT0tzorkIqeJoPjth69G3YG/gn7G3jLB2Gr3+fLMvShTR141jOAoyybhT5
rUtWWB7QHN1uGYyWugxaFX93t621zWETiJGIkLUqr4YTlhLxgjevD0UKqBgr4z9s
JjQ+DnQp7DGrFbHx9VtYVwMVmA4AchYUJmgtlgv9NoI+4fVJe7zuRC/bMQuj958Q
aKMWTppjrQOp3XRQAgcEmrfzVmFoErzFCvHo7xhZSptgQSzTomzfaZvWXD4iVN3V
G/2OipLqIb6qKUXmyZQU61uawGxHKnDfkd3vEH7+QODQDcMidvFW3AcQFpcnmL/D
ihIU53l/Kr9imgXLTetItAkgPh/KJeSXM6Q5B3JKyTMi6wg2VZ4MxV4CdqnYd7Df
sBLiFXSVT0t2FFVIJe1WV7QSqhk3tCp5Gw42agaUJTMmT3ZbJoK3ibC57CqssZkr
neScKZIFrk7vJiEdLBYhX1lIis9IMARnLEuUguKOxSP1yNL7sRQ=
=UAlg
-----END PGP SIGNATURE-----

--IJpNTDwzlM2Ie8A6--