Date: Mon, 17 Sep 2018 20:49:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Improve autovacuum logging for aggressive and
 anti-wraparound ru
Message-ID: <20180917114930.GC31460@paquier.xyz>
References: <E1g0aGi-0000uN-Sq@gemulon.postgresql.org>
 <20180914153554.562muwr3uwujno75@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="LwW0XdcUbUexiWVK"
Content-Disposition: inline
In-Reply-To: <20180914153554.562muwr3uwujno75@alvherre.pgsql>
Precedence: bulk


--LwW0XdcUbUexiWVK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 14, 2018 at 12:35:54PM -0300, Alvaro Herrera wrote:
> On 2018-Sep-13, Michael Paquier wrote:
>> Improve autovacuum logging for aggressive and anti-wraparound runs
>>=20
>> A log message was being generated when log_min_duration is reached for
>> autovacuum on a given relation to indicate if it was an aggressive run,
>> and missed the point of mentioning if it is doing an anti-wrapround
>> run.  The log message generated is improved so as one, both or no extra
>> details are added depending on the option set.
>=20
> Hmm, can a for-wraparound vacuum really not be aggressive?  I think one
> of those four cases is really dead code.

Sure, at the same time it is a no-brainer to keep the code as is, and
seeing log messages where (!aggressive && wraparound) would be an
indication of surrounding bugs, no?  There have been issues in this area
in the past.
--
Michael

--LwW0XdcUbUexiWVK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluflMoACgkQnvQgOdby
QH0UPQ/+M/QjhZ6GuOsSc/mEbRdDlz6UTLBudKuE+ndefqB69kdDVS5SJVOikNEW
HGj0pA2JoxpVr3fSbfNsNFfi8sBS/J1egeRMc2fuqD1pK4XcGHRv1+6JRCK4s4Pm
0nNJZNacRP+6HSOr3fvsyeQYUrT2bEkt8Kra44saDds+riGEIxtB0YMHMZQW8NZh
GFCu42xUkrmYZ0w4d4zyv7v83Qd6yL2ZLc9m246mR+eG1ZxlAOMK7yVVTJZISbri
OVrIQqp1O/g0Y9cs9+pzRGRmGcoFdGPgRNDoY4t9QXK7jNG2brESGGzW63eptt6u
I1CcBEMu/hKGnZ8MvNjioYppGD/ffxUblt/Ha/EuOFwiVKmRnZALk/Wl4RHMAj+y
jjifU+9E+Xik1N0AyiEn183oJ7swflRNAckWZvXiRDJyKF5ePlbpjxfnBHgTY/Td
k/EIABNA+f5up/8z+4qF4W4ya+r7t/2+GxtFxaVKmWxMhLOv0hPKe8aRdthSzch6
ctBwtSDnCAPRUF/v5cvQiV4IHmKkmOVTFBeiKCVsuUIJxM9oEjTYZ+lkO+WRnJwn
Pw+quiwg/cT7AtlgmBHDNjmuY1lAdHXCnaUCpMODdbOTAvQcbFgcpsFoLceAXqS2
1iSHRTItV99p2uenvUDXFWKlJv8/PRenh32TI/e+OUJAnuOBd8Y=
=7xjm
-----END PGP SIGNATURE-----

--LwW0XdcUbUexiWVK--