Date: Mon, 17 Sep 2018 23:02:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org,
	Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code
 for Wi
Message-ID: <20180917140202.GF31460@paquier.xyz>
References: <E1g0cYN-0003oE-IE@gemulon.postgresql.org>
 <23543.1536938575@sss.pgh.pa.us>
 <20180914224939.GA1178@paquier.xyz>
 <20180917114113.GA31460@paquier.xyz>
 <17194.1537191697@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dWYAkE0V1FpFQHQ3"
Content-Disposition: inline
In-Reply-To: <17194.1537191697@sss.pgh.pa.us>
Precedence: bulk


--dWYAkE0V1FpFQHQ3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 17, 2018 at 09:41:37AM -0400, Tom Lane wrote:
> BTW, I'm a bit concerned by the fact that bowerbird has failed its
> last couple of HEAD runs at the pgbench step.  The first such
> failure was here:
>=20
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dbowerbird&dt=3D=
2018-09-15%2014%3A19%3A58
>=20
> Looking at the set of commits between the prior run and that one,
> it's hard to see anything that could have triggered the test failures
> other than this patch --- but I also don't see how this patch would've
> blown up pgbench without breaking earlier tests.  Ideas?

Thanks, I have been looking at the build farm but I missed this one.
dory, which uses VS 2015 is not complaining because it does not run
bincheck.  At quick glance, it seems to be caused by process_file() in
pgbench.c which would need to open files in text mode, and the input
file parsing fails at the first '\' character found.  I'll test that
stuff on tomorrow morning manually.
--
Michael

--dWYAkE0V1FpFQHQ3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlufs9oACgkQnvQgOdby
QH3w7Q//W1YqKG5+qJCqTCSmOzZqMCLBxeNeKvfWsFzPvK8PHJzFaQUqirNC4iXv
aAIGTEKCFBvX2ocK2A/5s+eFc0LNZ0h5Z9QYsvI65C1wH/dd+q2ESRmVhSZrn4QP
RYbxoQdLKuRErE59xnzaB1mCF4qRVeCUp8p1IvwwygCji5WZ1l0ToScDE+FW3QRz
DPybqOHy78NtwQDLEkRrSdQ1hI95cm2UR1++0XrpGA2DcWA0E+eX+vRe+cfBbEI/
yAdzms0fGdGwMz26t09+RIzHS0sycRqnrEurSQR8g+DrpMqQ9WRDeJaV8ANVlUqt
pfK2BFq4ahMZlLyRhrR0z9w+wLjLLhhBwvoakBuAIacLPGc0rOWxIM/ORfqnp2eL
qtQD5zGJYaQ/yUbS4RrFqmBydLyllVU6IVL8S4KmKMc68S7qLA9GCzMXLY53U+Pm
EraAbLmhVVpmkTtyquj5pkAfmCc9gZh5VEVl95qRboWGt8bxR3JtAANnQ3hlj6j8
FwHMBeGLB/FePP5hAoG61MqkA6WvIUVKGF9ozYFY76MkzrxW4RXgM8G6P0NYVaR2
SaSFt7+UeD4kNbBTtMJ3vjCrYyZE/bzmZyCOu+B+OiKRUpYPYfTr1PtYNIhPa6Q1
GURylV7Fh0+GZjzu+nuqzbzOaFmBvrQfrYhoS49+GLKWb5SNRX4=
=iqy3
-----END PGP SIGNATURE-----

--dWYAkE0V1FpFQHQ3--