Date: Thu, 20 Sep 2018 08:58:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code
 for Wi
Message-ID: <20180919235820.GA1338@paquier.xyz>
References: <3883.1537200836@sss.pgh.pa.us>
 <11148.1537227504@sss.pgh.pa.us>
 <20180918001143.GG31460@paquier.xyz>
 <20180918024227.GI31460@paquier.xyz>
 <23296.1537281909@sss.pgh.pa.us>
 <71bf47219037a5e3839748eb55e4fa175b58f523.camel@cybertec.at>
 <25361.1537285137@sss.pgh.pa.us>
 <c68010480459c79f24a015096ae43b6f0bcd9854.camel@cybertec.at>
 <20180919023211.GC1650@paquier.xyz>
 <26882.1537372501@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="J/dobhs11T7y2rNN"
Content-Disposition: inline
In-Reply-To: <26882.1537372501@sss.pgh.pa.us>
Precedence: bulk


--J/dobhs11T7y2rNN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Sep 19, 2018 at 11:55:01AM -0400, Tom Lane wrote:
> I'm OK with this approach.  I wonder though what happens if you take
> away the "#ifdef FRONTEND" and just enforce that one or the other mode
> is selected always.  That would seem like a sensible solution rather
> than a wart to me ...

Thanks, I have pushed the solution from Laurenz to maintain pure
compatibility.  The origin of the failures reported by pg_dump actually
comes from a mismatch with pg_hba.conf in the way users and/or databases
are parsed.  I am glad that we have tests for the full range of ASCII
characters in TAP so as it is easy to detect regressions at early
stages.  We could try to manipulate more setmode calls like the one in
miscinit.c so as authentication gets the right call.  I am not sure of
other side effects though...
--
Michael

--J/dobhs11T7y2rNN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlui4pwACgkQnvQgOdby
QH38uhAAoWn9ggAAOhsO7miurgdRLiC149WDhcIwTg8dLviCu+92hvrqyLIK+BzX
Bc/LDNq/kTYxiGF1VAcCLCKODx8ezwYVOStRBPh4UjBR/K1G/TNsV1J5DOz719Xp
2Sguk0LmD+wrfRsRz5ms6ggLf2O4/CLm71UOWqiTKkpyVPJWQsOcA7G2St0fjLsN
cviNGl+FWIrxOYV18ZVR7LR9jNYkslBrXijeRpuxlj7f9ZNLrF13oqiqVL15GOtQ
KmRb7ePYnNi2RxzVx7nHIR0PSFrteXi38JzVpdjp1rJ387seCNcDG69oun6puNfU
zb50vl3exY47b/QDGHEZWryGT1eILj3XuyvwdITx3GVFBCtoJQBKFxVOU19TGlQz
onmmG7FSB2w1/cmGcCkSKpo1QkjYicxu0Tj+Hg7yFCT86MYY44DxepmlC1iBGSEK
rnG30g/4LQ50HkA2B0VPMDG+nqvkNXGsJoeHyryvilAnEBoAGg3qaYAcgkGYBssQ
EAvjBQICEanGOlNcPahMr+HfyAoHuKVXJHRvROgTFqYn8DwkBIBoh3UyWh2bl4c5
MUA2AlPMImweZHjHs20g34Xs0Im9YcZLukKu7zN40/a3DJJfa5awg/VbvycZfAQf
XhE9Lp45rs0QRNhF9fvgoZg60kbmOQAIX2iSg02ti3CFbY5/D0k=
=FoLu
-----END PGP SIGNATURE-----

--J/dobhs11T7y2rNN--