Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g4xJd-0006eu-1T for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Sep 2018 00:04:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g4xJa-0001ZO-NA for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Sep 2018 00:04:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g4xJZ-0001ZH-Re for pgsql-hackers@lists.postgresql.org; Wed, 26 Sep 2018 00:04:26 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g4xJW-0001XQ-M7 for pgsql-hackers@postgresql.org; Wed, 26 Sep 2018 00:04:25 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id ED1E02AD; Tue, 25 Sep 2018 20:04:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 25 Sep 2018 20:04:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=2hEeajuc0ZCO9MDjA4f10dDiSDlfkUe2H59RkikBnQc=; b=TBp4zmsa a/34ldL4A/3i8F8cwmADj8pvcInW1SpjNctpKuKideQc8SeMOPFcx+lB/WMZThks JV6Ug8PQKadTrHhFqpE76ikoL4lsZW5Gr1oX2f8BM7XtAIzB3euBatS9lk5hQza+ yTdoCuRuV//govLuXy+2f8/l1u2Hn7GiWCrIki6we+HRqYyoE0Io/shoy0AoZ6Vi m5c/eNT2QRIqsJMDjt1hBRqr1Xd9lKG7FlWCKq3J7rHqn4IfNzZPp71gu3Z03WSs yPo4UmJB20NhVvlTTPv0L7OPeN5iI13zDpQ5SE5EHn9q9sEyr+N+KGk/hqUStTYZ C5yF+DRYIzajoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=2hEeajuc0ZCO9MDjA4f10dDiSDlfk Ue2H59RkikBnQc=; b=gjqTy4koOIEz07Q2OyhDWxcChSsVdtmM76bneImODc45W xCUCUbUfwmbfps6usiDcO2GvMdjYSMWRGEHeHP+Gusc+A06O8hZKFdnVo85eylzK /s0t7G6Mz3lvp7FwEubc1CLKMMKF5PQPZIO4eYLX4V4Q0Q/TAcZjSFevA3knsE33 MK5HbYbAXMkSUMTOpn2VVLiybsl/g+YTjRXy4jcLBP8a7NHcKYfFaZh5csJWfMOR 2E+e5RHtpaelR2K9VAwQdL1YKT4INQMFfTokiCw/S2b4PR24Yz8S8VXlTdePcZex rTOR6C2S90kz35TPmEAPJsShr9uGNJvljsXNeAzmw== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id B8FCAE474F; Tue, 25 Sep 2018 20:04:17 -0400 (EDT) Date: Wed, 26 Sep 2018 09:04:14 +0900 From: Michael Paquier To: Andres Freund Cc: Postgres hackers Subject: Re: pgsql: Remove absolete function TupleDescGetSlot(). Message-ID: <20180926000413.GC1659@paquier.xyz> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="adJ1OR3c6QgCpb/j" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --adJ1OR3c6QgCpb/j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andres, On Tue, Sep 25, 2018 at 11:39:05PM +0000, Andres Freund wrote: > Remove absolete function TupleDescGetSlot(). >=20 > TupleDescGetSlot() was kept around for backward compatibility for > user-written SRFs. With the TupleTableSlot abstraction work, that code > will need to be version specific anyway, so there's no point in > keeping the function around any longer. There are still references in the code to this function, and a declaration of it: git grep TupleDescGetSlot doc/src/sgml/xfunc.sgml: * user-defined SRFs that use the deprecated Tu= pleDescGetSlot(). src/include/funcapi.h: * user-defined SRFs that use the deprecated TupleD= escGetSlot(). src/include/funcapi.h: * TupleTableSlot *TupleDescGetSlot(TupleDesc tupdesc= ) - Builds a src/include/funcapi.h:extern TupleTableSlot *TupleDescGetSlot(TupleDesc tup= desc); -- Michael --adJ1OR3c6QgCpb/j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluqzP0ACgkQnvQgOdby QH0Q4g//R40bV9EhGZ7Yrg5h+5np2OmRIsnRGCcsnFqVNwCUVJihFEI69SQk27ae m1iU5hBYJo1mbyNl50SEDraMGxmr/fw9Hycj6THwXllqVtJE7aNuevEDnX8249kC Nqb0i8enG54KrtRbgf4BCF98R6sZSKJ9m8fQNWLJrI8vJF0TLfiQorLUAhY3TmPS gEqfukWAn8SVnUwoUtaYYZ+DOqjjNdtWjj+fckqTKcT/UgrPw+0SWMhR6fs0SKY0 uYPDpSw86BLwWEPWe7ZPLlxa4a1hh2/Jw63UHZgeH9l2YcSoAJfB34F0iq37W4Yl Mz/l4B59Rq/NndvA1RD7/GkkjgWhzGcudiz4UlfrJspYfobSng0z74yHhuW2R64c heiyMoe4/wbwS3+D0vhVHH5+R5YgawLyhT/JRdwpKM42++tzoc/js9E18aGW0Uza Dn+eiBoaGiroWeC6RzZsPElyQgN7sVfnpM5UBEAqcQfbw1tcjoQ6xuJsnGP1TqE+ ywjRJvXkb+ORFKxgfcSDtHOSti3vZ4RYLt47sHIVThaHiZm/1WT/lj8OxfV5jb3s 0AArhzDGmBHtahoeaxKjTBOa6mxC2MnvRki6p8ttzhUx+NfGsKom7iRFTeg1MlOh VWBNjI7R8cUDSaJ/uQ8r9RspWK8Q9deq/R8PGlQj8UooDCqrO/s= =nVju -----END PGP SIGNATURE----- --adJ1OR3c6QgCpb/j--