Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g4ynC-0002Wx-Kr for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Sep 2018 01:39:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g4ynA-00089d-SD for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Sep 2018 01:39:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g4ynA-00089W-LD for pgsql-hackers@lists.postgresql.org; Wed, 26 Sep 2018 01:39:04 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g4yn5-0003dq-M2 for pgsql-hackers@postgresql.org; Wed, 26 Sep 2018 01:39:04 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id CAB0521E; Tue, 25 Sep 2018 21:38:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 25 Sep 2018 21:38:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=MDwgs/hzFWYI36+8tWBpjHehKx4wZNl7eJzfXP/NjQo=; b=FDz8ViQx UpeaX+K3i+9+leECGovwO4e/sudxrOQBNFxEDoQeQzklngk1MXa1NHl4f+DemJSe dOuPTwHoFvhwUMHouwl9STw/oLIJM7AqH+sdmIN1n0taIpErhWMszoaFURmHrZaU JODDdqjI3rybraU50KEcolOdVUh8tDxx9eRqw73L0+7AT0xmeDDuztLU1SJl7g/X S5ThPvyUiDTnqM07JaESCV5IAxI3apBGL5N9YW31QMsRziKpNpAetAVko+FkO0JH Y/iNuvhUNMmpttTsZNKBiHMKtWTodW82DyOYG2RkjE6PARB3tlq3dZgS8+/UC6uh tdrCu/FmlSSeQA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=MDwgs/hzFWYI36+8tWBpjHehKx4wZ Nl7eJzfXP/NjQo=; b=gIiDyEi6MkuthM2Lveiu0cYv9em1tVQH0rLrjKrN7ARjK zMCIAiJK79QJwLUMtacxAJx/Dm1FP9R03krcetWq4XoN6vLCaiVVuOCxeEk/vdyh yERCyTc/C0OMCVdZOC7iNvoSkL8lNLElXLEW7Z5fZ5CFs5C8rPG4beeWe23PyOa/ j6C3P2Ecs2osC98z5jrGC8TzlEoWBCMgRC7aYggm4wHkvOpsofF8gEiWfqDWVlzM LvhR1D2wNA/Q/NBWLbPejGBUUUbU86X+0ZvPqlZoZkrePiHQ8OkjukLm++KyuKql IWSEFY3UVmYaLtMBV3pXs01yH/SDXiwkOVLW0wfKw== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 9B3B0102D2; Tue, 25 Sep 2018 21:38:54 -0400 (EDT) Date: Wed, 26 Sep 2018 10:38:51 +0900 From: Michael Paquier To: Andres Freund Cc: Postgres hackers Subject: Re: pgsql: Remove absolete function TupleDescGetSlot(). Message-ID: <20180926013851.GG1659@paquier.xyz> References: <20180926000413.GC1659@paquier.xyz> <20180926001038.fh7rrhrqrwvpu43t@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sLx0z+5FKKtIVDwd" Content-Disposition: inline In-Reply-To: <20180926001038.fh7rrhrqrwvpu43t@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --sLx0z+5FKKtIVDwd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 25, 2018 at 05:10:39PM -0700, Andres Freund wrote: >> git grep TupleDescGetSlot >> doc/src/sgml/xfunc.sgml: * user-defined SRFs that use the deprecated= TupleDescGetSlot(). >> src/include/funcapi.h: * user-defined SRFs that use the deprecated Tup= leDescGetSlot(). >=20 > But here I'm less convinced. It's not entirely clear to me that the only > real reason for this to exists actually was TupleDescGetSlot(). OTOH, I > can't really see any proper reason to have it either. I have not been following the recent thread about the refactoring of TupleSlot and such very closely, but if you don't plan to use TupleTableSlot in FuncCallContext in the future, cannot this just go away? The function is not here anymore, so my take would be to get rid of all things which relied on its presence. -- Michael --sLx0z+5FKKtIVDwd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluq4ysACgkQnvQgOdby QH3SGQ/0CSaIAddLkBsO6amlBnMwi8PMryZgSZJkdn2RdS/t4Zp8kHzmCD6YZCwL 7jMFGIXdt5Ac6ADTWuwI94JI061I2jIapgx5H5QzsxJyqTgVHgBT/XYM0EXNWJZV ziAvnfGoM0HuN3mMGVv3YPHQneDboGCGKhR+Rt9/o5s4f1y3IS03ngoDYFCnpr/r MeOrW9VCnMwN8bLV3Xg3zUCg+3adp4JQKvap5tQlPsu4ZNYsCFuay/XURzP7Y2lP VEcVEWwgec6gjMXlJyYlEt+p3krKZ7VyFdLW/dJSsbFWj+dsJRol33PdwksflqKt Sw7vPKwjkIKZ3dbGebZtfLWAepIpcJSQGw7jbckyxM8UO9TKqUSr1KAwLD5Y6n6w ZrUX1IwxunOvTozDXWMktqzga+HrWs59hPbAkkJja7oYfMwuf2jsK8Ucyt7FpWC2 42LiCMLd5rIw2WF3IhKUG05OGI1Glh98DAjPL3SXAO6bhElyr296KipOGCwSfgPB NmJ978j+Jg9BC36EBFEKrKbxQ7YQQx35whXHoanmnR4L/7koxngJsprDNC3nz7zs UBwAXPPzkT7U7SQItPCfGXS6ef7nA2Cjl66s077NnfZdKLyebHyz7pMGW02xrg2g jShBDTgblSlrZot67apcIvFVyBjLBOEaEX4IZX//gelbeK05iw== =Tjky -----END PGP SIGNATURE----- --sLx0z+5FKKtIVDwd--