Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g50hy-0001MC-HB for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Sep 2018 03:41:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g50hw-0001dj-Ko for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Sep 2018 03:41:48 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g50hw-0001dc-9f for pgsql-hackers@lists.postgresql.org; Wed, 26 Sep 2018 03:41:48 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g50ht-0005Gh-0P for pgsql-hackers@postgresql.org; Wed, 26 Sep 2018 03:41:47 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id CD2E33E1; Tue, 25 Sep 2018 23:41:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 25 Sep 2018 23:41:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=XYQpDpWby17uV3af4H0E8gOZv+UX1CtmTKyG/2fL1is=; b=IfDBrBux MCMUjCFEe/QtQfdAK4mEPUGa3Ocscxl59N/Aqurj8KC0HZb6Csw0dMQ+BanHKSPU dJqwVQc9JN9tCF7G5tGV3fyUVgtUuPQ4AavpM/l11SDF4e5rtdAFNo2ufiupzfEF 8H8I4EvMQ95SaEzQ8tVmUmRMb9kGJyC4sbtDF6ao5sp48OSLKpJ5EmtKFBc+y1LE ihBn6YrjIMylSqxN56CKq5JJ5ToJa1/mNjUm/Hvcd8ulJ5ADfmst1d7SyJjO0Faz U4sgDZeEeCk765AE8PgLP4TSXQWQ0HQ8WZHlillXFCpcLtVO7g7Vnq7iXqngmJ8z KiJuSN8/N+s2Yg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=XYQpDpWby17uV3af4H0E8gOZv+UX1 CtmTKyG/2fL1is=; b=jdtE3AHB3/EE79jmDt4RIGT+EXG5/ocsnDpKO+QfRamv2 7Y4+hti5COV7Mxv+CBcodQ+Oe3iZBcaqz2QUn0hG+6FO7sv0qQU2yH3pAW0+94wD aH6gJwWRCM93rtiNT9QdNhET536M/CadrsVlgGTc3i/UPDy7XbiXro7naD9tpAGu uFSZFQtX7GzyGaDiWhDAd1lYBDnDockQrxUbYtjvc6NSForVOi4LCvek3wlXTWO/ ZSSo+WtRTVbZykSiNbzmQuruC+smPQ6Kvqg5tGyB5sQajaIuj1DzxXvMccHhyvpI +3V1CkyjRkh3HL+67xP/+j7hvIDJ5h/xyHPSBmn6Q== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 6BD9AE44DF; Tue, 25 Sep 2018 23:41:41 -0400 (EDT) Date: Wed, 26 Sep 2018 12:41:38 +0900 From: Michael Paquier To: Andres Freund Cc: Postgres hackers Subject: Re: pgsql: Remove absolete function TupleDescGetSlot(). Message-ID: <20180926034138.GI1659@paquier.xyz> References: <20180926000413.GC1659@paquier.xyz> <20180926001038.fh7rrhrqrwvpu43t@alap3.anarazel.de> <20180926013851.GG1659@paquier.xyz> <20180926014251.zrn27ljtqlqjzswx@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="T4IYkFBVPN84tP7K" Content-Disposition: inline In-Reply-To: <20180926014251.zrn27ljtqlqjzswx@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --T4IYkFBVPN84tP7K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 25, 2018 at 06:42:51PM -0700, Andres Freund wrote: > My point is that FuncCallContext->slot isn't actually all that related > to TupleDescGetSlot() and could be used entirely independently. That's fair. Why not just replacing the existing comment with something like "slot can be used in your own context to store tuple values, useful in the context of user-defined SRFs"? Just my 2c. -- Michael --T4IYkFBVPN84tP7K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluq//IACgkQnvQgOdby QH0CbQ//Q74OABq8PSbtVuG+SA9ugoSCZ5MbnmZdDt7ns7Kbotz1hTmQX17XJv7P oCMIrGrQg4sVybGIjPuYW3cvsbrUR7c/YTrpMnDBpdFPImpelW2N00+h/BBN5/Df mXcPsestFGzNce4jz5xNWTQYFTIBB6zM+BBfemACo7exMhGs43pgm9s0iSVd5umw VcUdnZ+R8mpNnnUPQ1feZtt0O5PYtCOBZmzUmXOabF6UK28ldKpbHvQB2w4fOzNo 03jTxpt2cJiduMNe6pb75GSwB9XlZkYnEnUZxhCvEm1iNXxA7RPQ2fQiC1udFLeb jDbqVM0GyUrPGIKvrVxS5rII2eopkDlnyfJMcmdy2DoskK7C2588hI9cAk98Yh8h j5iUAkBfLAoyZ96mvKJKqKcOxXW3tMdS473Z5QHFChbrzaHA/dVK4aK9hEfn50E5 YAeVoBhp2TSBYzvhDAesKgialCL+Xtjaz0x4EBamtJ5bQmqp0ntvov9FW9b43TDR w/Xo9SQLjydgICpmZ5Z5rYvxknT60ZoLkpR+jrhcj49cqiBmXBn4eCUgKdpvI4ou 7GVU/UVhdA6Czcr1CdAWuTiUq+x3Wx2XCJt21IIcuZ05BE7ewMTBOwgOsux8bJDy 5/w8Ua09JfVmQ/biAgMniuKv0Qp+lxInrQZhjo+yL2tWy23aGX4= =u3KG -----END PGP SIGNATURE----- --T4IYkFBVPN84tP7K--