Date: Wed, 26 Sep 2018 12:35:25 -0700
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Remove absolete function TupleDescGetSlot().
Message-ID: <20180926193525.7nbw6tnb35xcgtm4@alap3.anarazel.de>
References: <E1g4wv3-0001Q0-8n@gemulon.postgresql.org>
 <20180926000413.GC1659@paquier.xyz>
 <20180926001038.fh7rrhrqrwvpu43t@alap3.anarazel.de>
 <20180926013851.GG1659@paquier.xyz>
 <20180926014251.zrn27ljtqlqjzswx@alap3.anarazel.de>
 <20180926034138.GI1659@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180926034138.GI1659@paquier.xyz>
Precedence: bulk

Hi,

On 2018-09-26 12:41:38 +0900, Michael Paquier wrote:
> On Tue, Sep 25, 2018 at 06:42:51PM -0700, Andres Freund wrote:
> > My point is that FuncCallContext->slot isn't actually all that related
> > to TupleDescGetSlot() and could be used entirely independently.
> 
> That's fair.  Why not just replacing the existing comment with something
> like "slot can be used in your own context to store tuple values,
> useful in the context of user-defined SRFs"?  Just my 2c.

I've tried to do search for users of FuncCallContext->slot and couldn't
find anything. Therefore I'm more inclined to drop it too - just about
all cases where it's useful seem to require a more extensive
datastructure around anyway.  Unless somebody protests I'm going to that
in a few - if somebody later in the cycle signals a need for it, we can
still revert that part.

Greetings,

Andres Freund