Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1g5rPx-0001kz-E7
	for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Sep 2018 11:58:45 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1g5rPs-0002hC-0D
	for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Sep 2018 11:58:40 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <cb@df7cb.de>)
	id 1g5rPr-0002h4-PT
	for pgsql-hackers@lists.postgresql.org; Fri, 28 Sep 2018 11:58:39 +0000
Received: from feynman.df7cb.de ([195.49.152.168])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <cb@df7cb.de>)
	id 1g5rPl-0003gM-BY
	for pgsql-hackers@postgresql.org; Fri, 28 Sep 2018 11:58:39 +0000
Received: from msg.df7cb.de (unknown
 [IPv6:2003:5b:203b:100:7627:eaff:fe52:8e03])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	by feynman.df7cb.de (Postfix) with ESMTPSA id 42M9Dl3Mv4z3Dyt;
	Fri, 28 Sep 2018 13:58:31 +0200 (CEST)
Date: Fri, 28 Sep 2018 13:58:31 +0200
From: Christoph Berg <myon@debian.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use
 that in li
Message-ID: <20180928115830.GC26142@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Re: Tom Lane 2018-09-27 <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
> Build src/port files as a library with -fPIC, and use that in libpq.

This made the "pqsignal" symbol disappear from libpq5.so:

13:27:55 dpkg-gensymbols: error: some symbols or patterns disappeared in the symbols file: see diff output below
13:27:55 dpkg-gensymbols: warning: debian/libpq5/DEBIAN/symbols doesn't match completely debian/libpq5.symbols
13:27:55 --- debian/libpq5.symbols (libpq5_12~~devel~20180928.1058-1~226.git92a0342.pgdg+1_amd64)
13:27:55 +++ dpkg-gensymbolsoXZn54	2018-09-28 11:27:55.499157237 +0000
13:27:55 @@ -168,7 +168,7 @@
13:27:55   pg_valid_server_encoding@Base 0
13:27:55   pg_valid_server_encoding_id@Base 8.3~beta1-2~
13:27:55   pgresStatus@Base 0
13:27:55 - pqsignal@Base 0
13:27:55 +#MISSING: 12~~devel~20180928.1058-1~226.git92a0342.pgdg+1# pqsignal@Base 0
13:27:55   printfPQExpBuffer@Base 0
13:27:55   resetPQExpBuffer@Base 0
13:27:55   termPQExpBuffer@Base 0

Is this is a problem for libpq5 users?

Christoph