Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g7EaX-0006hy-1h for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Oct 2018 06:55:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g7EaV-0006qv-0b for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Oct 2018 06:55:19 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g7EaU-0006qc-Mn for pgsql-hackers@lists.postgresql.org; Tue, 02 Oct 2018 06:55:18 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g7EaS-0002Ft-FT for pgsql-hackers@lists.postgresql.org; Tue, 02 Oct 2018 06:55:17 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D74E521EA7; Tue, 2 Oct 2018 02:55:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 02 Oct 2018 02:55:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=u2Ji1+8K2HM3bedCSahdKioDeKgTlu8rQC8nXhCIsFI=; b=3A2vtxi2 Fq6HFtsQLVrxrJ5tEwJuDmV/Ky/zokthImIjl2ErAp7Kmfeilz19VbfNjiQIg9kh MmCsIvp5hNDxM01wKxLRkU1ylA3hU/2FSqBpzKa57KqsoPXKt5WPPJ4q6jdCJkaH DpJBQ1sUT+bntyM+GGnABOh3DEcX+aNagvbiBGF3UYB5HxK9PxrDSVAqZI6654sc qTSjiZiCiHJMhl+FzZetF01mL7q6bJlpUd1UbvVA1Z6WyCk00GAOCPmDPlOJk3h7 Gia0obNyH5azUKzJSHIibVE8cDR8JzuiSQmbNyQ4we5CablWPiYRBirPFtFNkdL/ sZvCeWWPklxqbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=u2Ji1+8K2HM3bedCSahdKioDeKgTl u8rQC8nXhCIsFI=; b=i4GYDFqTIlS89ZH2jd5BW8/N3FTtCYE5pKgC1apiAKgBT SnQcIcLeQdqIOKPBszu+OA/qKehGyzgJ7njcRLl4o7xEXIkISlznkKiJ5B439OgU XNXHbXRis9OBwmDAtikl0CGtQ6eyGArmpr7Of+Fp9SEwBdekAPUYG2Jk/l7JTD6L kbVjwPrck3CZ/8BxB3SH8rdk8J9HobruCojTQpDPBNQ1k/ugsF47hce1f5ITNU1c Dx2OfzAXqBeGlrqdR/VQuzmL/GcuOHzpbZqbk1VaiQtvsHPobWJj7DNZ6JYKREac kCWgBPfVXanR5p2zVLoHxp8gyEY2qhfeJq69kWdzQ== X-ME-Sender: X-ME-Proxy: Received: from paquier.xyz (mp76f1fb95.ap.nuro.jp [118.241.251.149]) by mail.messagingengine.com (Postfix) with ESMTPA id 53893E4A3C; Tue, 2 Oct 2018 02:55:12 -0400 (EDT) Date: Tue, 2 Oct 2018 15:55:08 +0900 From: Michael Paquier To: Masahiko Sawada Cc: Alvaro Herrera , Sergei Kornilov , nasbyj@amazon.com, Andres Freund , Robert Haas , PostgreSQL Hackers Subject: Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru Message-ID: <20181002065508.GC17642@paquier.xyz> References: <23209391537822541@iva4-6d7004ac8463.qloud-c.yandex.net> <20180924211117.tpwxemzd3372nagj@alvherre.pgsql> <20181002001151.GP11712@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PHCdUe6m4AxPMzOu" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --PHCdUe6m4AxPMzOu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 02, 2018 at 01:18:01PM +0900, Masahiko Sawada wrote: > I'm not sure both styles would be appropriate style in the postgres > code so I would rather add elog(ERROR) instead. Thought? My brain is rather fried for the rest of the day... But we could just be looking at using USE_ASSERT_CHECKING. Thoughts from other are welcome. -- Michael --PHCdUe6m4AxPMzOu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluzFkwACgkQnvQgOdby QH3S8g//UwLeZL7jSXo85bPz5l+jlkdxI1eB/7b8kqdITsMfMStzyzYtiLERxltC NhBelbf/D3cOXdZWPSQyPJljqs6Yiwp0UY+4C+1ylXCB3zM9xeYSVYmaEdrBO5L8 2Z9VcHUMMTSujeuMdVpj/8wYD7YVyfsc1UeqVKffJBOo9Yo2IDHTFocMvD5TUudJ p18qXg2hNjXfX3MMSHq4TpoMHM7euLkfQqkdgBLNIc5zS+eHsuvQGqvL2Z1A4G79 E1U4Y3Igox4Kzqf+goPAx+je7+V+eeOXj15y3JKjoUzHecV0ohSQH6UTEuKDYVN7 HMwU8C+Lf7DZut8vw0HMQaygXlQpvOPNMibYR/eVSpf/vT/RaEmr5OqZTpZSV2e/ ObKVe1hMqMtodZX5b9VUGFTvi+HcKXX23wKhLdJV/XfS5rCyHFdBGJSwwgkpge6k HCAikPMmtP1fzWNljVRM/DsMK4QVRawnYTkjHSIm1eNeJhdaPD2QYOe3+u95aP/i eNYC+9P9TsBhYO6cvPjMzGeUwfWvIMTDILuAPAYdLvOWGKb+Y/WgGRHnaFXukfgY 2wRYkCyJeQdSuIL29pmoMv37k1W+CtMlOf9FqaSo5nwOGmPxBbYhQmADp6FVKVVO ViUESiuTJ015v74sEuY0ENoXcNdIxruHiDKpBKjMZ0yQVqi6r1c= =VCHS -----END PGP SIGNATURE----- --PHCdUe6m4AxPMzOu--