Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1g7nmo-0000VQ-5x
	for pgsql-committers@arkaria.postgresql.org; Wed, 03 Oct 2018 20:30:22 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1g7nml-0000Mi-CR
	for pgsql-committers@arkaria.postgresql.org; Wed, 03 Oct 2018 20:30:19 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <andres@anarazel.de>)
	id 1g7nml-0000MZ-3U
	for pgsql-committers@lists.postgresql.org; Wed, 03 Oct 2018 20:30:19 +0000
Received: from out3-smtp.messagingengine.com ([66.111.4.27])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <andres@anarazel.de>)
	id 1g7nmh-0002US-JZ
	for pgsql-committers@lists.postgresql.org; Wed, 03 Oct 2018 20:30:17 +0000
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
	by mailout.nyi.internal (Postfix) with ESMTP id 8575421C24;
	Wed,  3 Oct 2018 16:30:14 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
  by compute5.internal (MEProxy); Wed, 03 Oct 2018 16:30:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h=
	date:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=fm2; bh=HP8ifnRpHtg2tKrcmHPL2F4Tmjc
	fBJsXKNOPfAwLo98=; b=nk0LqRZOuZZDulH/IZeYxFSuo6K7n/ZNiosSxF4y/Et
	Oa4FskYSFWBJaQmQo5Flx/99dE//LdP/Ekr/MmCblqTtuItF+z+Ko/yl7j0JgBFG
	1GzuEjVzbzSXVRcrK6Xq1e6c0PLcPt3KAZBKTn38GWCMyMm5cf/zC4hnmdpD/vmi
	3eLAojsC3YwfLQZMB5CBZA3QE6ttgeINyv2VizJ8f5o6J/6x/9YVX7PmfAHvWv9k
	cAe1Rmfg8HT+rEnleZTkGBjrIgk3TedRar3b+xnlATCIq1r9U6HS3jpi+Cw3Wesm
	c+P2Xi0aPma5D5jLDadBE9tIfmpLJTELO8hoLwv30Tg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=HP8ifn
	RpHtg2tKrcmHPL2F4TmjcfBJsXKNOPfAwLo98=; b=bnkcAzg3rPnf5lvqNt6S/1
	4bb3EX0WIC6W6vP3BDHgA4H4TvlQoMIRoCytN0rvIYPhjffq05pxdYl/p3C3dDYx
	8byExILXXODLOVLQ/JQHRAV5/0U0/1s+5U+pR+hjA/YFheDKZX8XtRX3gi4rhIf1
	hgaHvIFZHKdXmpEfkubXetgfl/mgEG8z2KVAH68BtxZZywR+Sjj2e5k7jQOBDl4R
	sPgl8V1q/30iMPY4XIRSCB1+Vu3AoqZCfKItllWakQ1irmG42Trz2SHDB9+1BQ6+
	LqirOZtxkRb9NoryNTgJLDUFnDyNWn7SG0s/NRNBMwdPlTxbihlI3P57fFLwdTyw
	==
X-ME-Sender: <xms:1ia1W8DlbhFfgHKr1Itn8ptofIno09vzwrRQZAzSweHeTZv81S68Hw>
X-ME-Proxy: <xmx:1ia1WyqQsfA-dkXNS7vJqZ5pmkODMnKh2GGi6-WmGVX1GyoYfyaUhQ>
    <xmx:1ia1W4R5sska7XOOJnfG_gBT-d837Xh-J1jdvXbSkHS65lZDL4Wzjg>
    <xmx:1ia1W01QQ0YYBS5WRUlypb2v9FsJCQDnr9-tyThykhzbZFvBXFIDCw>
    <xmx:1ia1W8AcV8X53aqOSrNjnxYbZViEfD-vF_VJNnLUrxDJ-CQ0hem2qA>
    <xmx:1ia1W4jb1L_iQbuANZ_uXh_L9TYrJu4bzhXzR-nlQPT8OfGiBv_pMA>
    <xmx:1ia1W8KBCI_BzJx0SToKoxwxa727iK0oWfTP_paErgEabhwl80vrWg>
Received: from intern.anarazel.de (c-98-210-140-171.hsd1.ca.comcast.net
 [98.210.140.171])
	by mail.messagingengine.com (Postfix) with ESMTPA id D5612102DB;
	Wed,  3 Oct 2018 16:30:13 -0400 (EDT)
Date: Wed, 3 Oct 2018 13:30:11 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Ensure that snprintf.c's fmtint() doesn't overflow when
 printing
Message-ID: <20181003203011.c2euts5hqhc6xpcw@alap3.anarazel.de>
References: <E1g7nZU-0000kU-MB@gemulon.postgresql.org>
 <527.1538598263@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <527.1538598263@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Hi,

On 2018-10-03 16:24:23 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Ensure that snprintf.c's fmtint() doesn't overflow when printing INT64_MIN.
> 
> Hm, I think you should s/uint64/unsigned long long/ to be consistent
> with 595a0eab7.

Fair point. Will push once tests finish.

Greetings,

Andres Freund